patchmldonkey, a multi-networks file-sharing client - Patches: patch #5065, Improved CommonBlocking

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5065: Improved CommonBlocking

Submitter:  pango <mlpango>
Submitted:  Mon 01 May 2006 12:10:22 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Postponed Assigned to:  None
Open/Closed:  Open

Tue 23 May 2006 08:35:53 PM UTC, comment #1: 

Attached an updated version of the patch for current CVS

 CommonWeb.add_web_after_hook (fun _ ->
    if !need_updating then update_bans ()
  );

This code leads to the fact that !!ip_blocking file is loaded
as many times as web_infos-records are present on startup.

2006/05/23 22:27:29 Starting MLDonkey 2.7.6.CVS ...
2006/05/23 22:27:29 Language DE, locale UTF-8, ulimit for open files 1024
2006/05/23 22:27:29 MLDonkey is working in /root/.mldonkey
2006/05/23 22:27:29 [DNS] Resolving [gentoo] ...
2006/05/23 22:27:29 [DNS] Resolving www.mldonkey.net ...
2006/05/23 22:27:30 [dMain] Libmagic file-type recognition database present
2006/05/23 22:27:30 [IPblock] loading ./guarding.p2p.zip
2006/05/23 22:27:30 [IPblock] guarding.p2p found in zip file
2006/05/23 22:27:31 [IPblock] 127405 ranges loaded - optimized to 111414
2006/05/23 22:27:32 [IPblock] loading ./guarding.p2p.zip
2006/05/23 22:27:32 [IPblock] guarding.p2p found in zip file
2006/05/23 22:27:34 [IPblock] 127405 ranges loaded - optimized to 111414
2006/05/23 22:27:35 [IPblock] loading ./guarding.p2p.zip
2006/05/23 22:27:35 [IPblock] guarding.p2p found in zip file
2006/05/23 22:27:37 [IPblock] 127405 ranges loaded - optimized to 111414
2006/05/23 22:27:38 [IPblock] loading ./guarding.p2p.zip
2006/05/23 22:27:38 [IPblock] guarding.p2p found in zip file
2006/05/23 22:27:40 [IPblock] 127405 ranges loaded - optimized to 111414
2006/05/23 22:27:40 [IPblock] loading ./guarding.p2p.zip
2006/05/23 22:27:40 [IPblock] guarding.p2p found in zip file
2006/05/23 22:27:43 [IPblock] 127405 ranges loaded - optimized to 111414
2006/05/23 22:27:43 Logging in /root/.mldonkey/mlnet.log

spiralvoice <spiralvoice>
Group administrator
Mon 01 May 2006 12:10:22 PM UTC, original submission:  

That's a large and untested patch. Caution advised...
Merges blocking lists in memory; When one changes, others are reread from files to rebuild merged list, so it can have a performance impact if one is using lots of lists at once.
Hits are saved separately from lists, so they're not lost across lists updates.

CommonWeb: add support for several web ip blocking lists. Specifically, added support for hooks before and after web info resources fetching.

In CommonBlocking: creates a merged list of all blocked ranges, for  improved efficiency, and for block_list output. Ready for several local lists, too. Keep hits separate from ranges, so they're not lost during changes.

ip_set: added a function to merge two blocking lists, with optimization.
removed merging feature from file loading

DriverCommands: "block_list": Display IP of hits instead of ranges. Replaced hackish html output with correct html_mods code. added "block_reset" to reset hits statistics.

TODO: Whitelists! Doable, but I think there's enough code to
test/debug for now ;)

pango <mlpango>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #10037:  5065_2.patch added by spiralvoice (20KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 3 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-06-06 spiralvoice StatusReady For Test Postponed
2006-05-23 spiralvoice Attached File- Added 5065_2.patch, #10037
2006-05-01 mlpango Attached File- Added commonBlocking_merge_fixes3.patch, #9865

Back to the top

Powered by Savane 3.13-f8d8.
Corresponding source code