patchBos Wars - Patches: patch #7106, SDL 1.3 SVN r5558 compatibility

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7106: SDL 1.3 SVN r5558 compatibility

Submitter:  Kalle Olavi Niemitalo <kon>
Submitted:  Sun 28 Feb 2010 08:27:56 PM UTC
   
 
Open/Closed:  Closed Status:  Done
Assigned to:  feb

Fri 07 Jul 2023 08:53:38 AM UTC, comment #3: 

After a lot of work, I finished the migration to SDL2. This patch was also used as a help and to double check.

Thank you for the patch.

François Beerten <feb>
Group administrator
Wed 28 Apr 2010 06:40:20 PM UTC, comment #2: 

Post-poned as SDL 1.3 has not been released yet.

François Beerten <feb>
Group administrator
Sun 28 Feb 2010 09:16:19 PM UTC, comment #1: 

Bos Wars trunk r9665 + file #19818 built against SDL 1.3 r5558 seems unable to enter full-screen mode.  Ctrl+F in the game does nothing.  If I enable full-screen mode beforehand and restart Bos Wars, then it just displays its window without window-manager decorations; it does not change the video mode, and the window does not receive any keyboard events.

SDL 1.2.13 has no such problems, with or without this patch.

Kalle Olavi Niemitalo <kon>
Group Member
Sun 28 Feb 2010 08:27:56 PM UTC, original submission:  

Make Bos Wars mostly compatible with SDL 1.3 SVN r5558.  Because of <http://bugzilla.libsdl.org/show_bug.cgi?id=962>, you must run it with -D 16 or -D 32 though; otherwise it crashes.

Three kinds of changes:

  • In SDL 1.3, SDLK_LMETA, SDLK_RMETA, SDLK_LSUPER, and SDLK_RSUPER have been replaced with SDLK_LGUI and SDLK_RGUI.  In guichan, arbitrarily map those to Key::LEFT_SUPER and Key::RIGHT_SUPER, rather than to Key::LEFT_META and Key::RIGHT_META.


  • In SDL 1.3, SDL_PixelFormat::colorkey has been replaced with SDL_GetColorKey.  (SDL 1.2 already had SDL_SetColorKey.)


  • In SDL 1.3, SDL_PixelFormat::alpha has been replaced with SDL_GetSurfaceAlphaMod and SDL_SetSurfaceAlphaMod.  SDL_GetSurfaceAlphaMod annoyingly doesn't return the alpha but rather stores it via a pointer parameter, so the corresponding variables in Bos Wars must be Uint8, not int.
Kalle Olavi Niemitalo <kon>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #19818:  0001-SDL-1.3-SVN-r5558-compatibility.patch added by kon (10KiB - text/x-patch - [PATCH] SDL 1.3 SVN r5558 compatibility)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by feb (Posted a comment)
  • -email is unavailable- added by kon (Submitted the item)
  •  

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-07-07 feb Open/ClosedOpen Closed
        StatusPostponed Done
        Assigned toNone feb
    2010-04-28 feb StatusNone Postponed
    2010-02-28 kon Attached File- Added 0001-SDL-1.3-SVN-r5558-compatibility.patch, #19818

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code