patchAVR Downloader/UploaDEr - Patches: patch #8996, Remove lock byte read mask...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8996: Remove lock byte read mask (bug#21954, bug#46759)

Submitter:  Milan Kupcevic <miki>
Submitted:  Mon 09 May 2016 02:54:38 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  joerg_wunsch Open/Closed:  Closed

Sat 27 Nov 2021 09:29:07 PM UTC, comment #2: 

Applied in r1500, thanks.

Joerg Wunsch <joerg_wunsch>
Group administrator
Fri 18 Aug 2017 07:13:48 PM UTC, comment #1: 

Are there any objections to merging this? It seems to me this would further increase the consistency between various programmers in how they handle bits.

There is a related patch at https://savannah.nongnu.org/patch/index.php?9110 that would also make things more robust by ignoring differences in unused fuse and lock bits, though I think both of these have separate merits.

Matthijs Kooijman <matthijs>
Mon 09 May 2016 02:54:38 AM UTC, original submission:  

The unused lock byte bits are supposed to read back as 1 by default. The stk500v2 reads the lock byte this way since r1336. To get other programmers to behave the same way the lock byte definition in avrdude.conf should no longer mask reading of unused lock bits.

Some newer chips already had the lock byte mask set this way. I've removed the read lock byte mask for all other chips with exception of some older chips that lack sufficient information regarding this issue in their corresponding datasheets.

Per Atmel recommendation the unused lock byte bits should be set to 1 on write. Users just have to follow the recommendation when writing the lock byte to get written and read lock byte to match and verify correctly. This would solve the inconsistency issues described in bugs:#21954, #46759 and #43421.


Milan Kupcevic <miki>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #37105:  no-lock-byte-read-mask.patch added by miki (23KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by joerg_wunsch (Posted a comment)
  • -email is unavailable- added by matthijs (Posted a comment)
  • -email is unavailable- added by miki (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-11-27 joerg_wunsch StatusNone Done
        Assigned toNone joerg_wunsch
        Open/ClosedOpen Closed
    2016-05-09 miki Attached File- Added no-lock-byte-read-mask.patch, #37105

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code