patchConcurrent Versions System - Patches: patch #4809, Tag extension for builtin tags

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #4809: Tag extension for builtin tags

Submitted by:  None
Submitted on:  Wed 18 Jan 2006 01:15:57 PM UTC  
 
Category: Feature (patch attached)Priority: 5 - Normal
Status: In ProgressPrivacy: Public
Assigned to: NoneOriginator Email: -unavailable-
Open/Closed: OpenFixed Release: None
Fixed Feature Release: None

Sat 21 Jan 2006 12:14:23 PM UTC, comment #2:

This patch agains newtags2 fixes detection of BRANCH.origin for BRANCH not having any commits.
It also includes the fix for some compiler warnings that has been sent before but not jet been applied.

Anonymous
Thu 19 Jan 2006 03:02:37 PM UTC, comment #1:

To browse the current version of the sources based on this patch:

http://cvs.savannah.nongnu.org/viewcvs/ccvs/?root=cvs&only_with_tag=newtags2

Some starting points in the mail archives with previous discussion:

http://lists.gnu.org/archive/html/bug-cvs/2005-04/msg00009.html
http://lists.gnu.org/archive/html/bug-cvs/2005-04/msg00065.html
http://lists.gnu.org/archive/html/bug-cvs/2005-03/msg00104.html

Finally, I'm not sure we resolved all the issues regarding .root & .parent. I'm not even sure we discussed them all. What happens, for instance, when a checked-out branch looks like:

file1 1.3.2.1.2.1
file2 1.9
file3 1.76.6.3.2.1
file4 1.102.6.9

Assuming that MYBRANCH is attached to:

file1 1.3.2.1.0.2
file2 1.9.0.8
file3 1.76.6.3.0.2
file4 1.102.6.9.0.2

Does MYBRANCH.root return:

file1 1.3.2.1
file2 1.9
file3 1.76.6.3
file4 1.102.6.9

?

Looking at your implementation, I can only say it might without testing, but your implementation looks much too mathematical. With the simple restriction that `.root' may only be applied to named branches, which I should think would be the most useful application of .root anyhow, simply looking the branch up in the symbols table and de-magicing the revision you find should yield the above result. Anything else lacks determinism with files that may not have been checked in on a branch.

I think your .origin implementation may have a similar lack of determinism when dealing with subbranches (what's the result of MYBRANCH.origin when MYBRANCH is a sub-branch or YOURBRANCH with no commits?) and a similar restriction to working with named branches would simplify the implementation.

I suppose it would be okay to leave the current implementations in place for when the .root and .origin are requested for a single revision of a single file, but I think the BRANCH.root implementation is important. I'm not as worried about BRANCH.origin since I still don't really understand why .origin is useful anyhow.

Derek Robert Price <dprice>
Project Administrator
Wed 18 Jan 2006 01:15:57 PM UTC, original submission:

A branch 'newtags2' has been started. It coveres implementation of several new tags:
.base
.head
.root
.origin
.prev
.next
.commitid
and the required fns to deal with these tags.
Details can be taken from the docs, subsection 'Tags (builtin)'.

Anonymous

 

Attached Files
file #9459:  ccvs-newtags-diff-2006-01-21-13-08-37.patch added by None (12kB - text/x-diff - Fix for BRANCH.origin without commits on BRANCH)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 21 Jan 2006 12:14:23 PM UTCNoneAttached File-=>Added ccvs-newtags-diff-2006-01-21-13-08-37.patch, #5793
Thu 19 Jan 2006 03:02:37 PM UTCdpriceCategoryFeature Request=>Feature (patch attached)
  StatusNone=>In Progress
Wed 18 Jan 2006 01:15:57 PM UTCNoneCarbon-Copy-=>Added frank --AT-- hemer --DOT-- org

Back to the top


Powered by Savane 3.1-cleanup