patchThe FreeType Project - Patches: patch #6981, Made some private cff calls public.

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #6981: Made some private cff calls public.

Submitted by:  bram tassyns <bramt>
Submitted on:  Tue 17 Nov 2009 10:23:45 AM UTC  
 
Category: NonePriority: 3 - Low
Status: Wont DoPrivacy: Public
Assigned to: Werner LEMBERG <wl>Open/Closed: Closed

(Jump to the original submission Jump to the original submission)

Thu 21 Mar 2013 08:11:02 AM UTC, comment #8:

It seems no longer of importance, right? This is more than three years old, so I'm closing it.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Tue 22 Feb 2011 10:53:10 AM UTC, comment #7:

Attached is new public header file, implementation and diff for cffload.c (also have to add new implementation where it's most appropriate).

(file #22754, file #22755, file #22756)

bram tassyns <bramt>
Tue 22 Feb 2011 09:44:35 AM UTC, comment #6:

Very good, so I'm awaiting your patch :-)

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Tue 22 Feb 2011 09:14:11 AM UTC, comment #5:

Those two are no longer necessary and can be removed.

bram tassyns <bramt>
Tue 22 Feb 2011 09:12:53 AM UTC, comment #4:

Well, looking again into your original patch, it's not only the static array stuff but also the `cff_parse_num' and `cff_parse_fixed' functions which definitely belong into a service IMHO... And then it's rather straightforward to add another function (or service) for the static table stuff.

But if you no longer need those functions, public table declarations are fine with me.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Tue 22 Feb 2011 08:26:49 AM UTC, comment #3:

Still interested in getting correct patch for official freetype,
but since our own version contains the required functions it has been pushed to the back of the todo list again and again.
About time we do a small effort so we can completely close this record :).
I assume you don't want exported methods in internal code, but making a service just to have access to a few static arrays seems a bit redundant, is it ok if I just move the table declarations to a public header?

bram tassyns <bramt>
Sat 19 Feb 2011 06:17:26 AM UTC, comment #2:

Any progress on this? Do you time/interest to work on this?

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Wed 25 Nov 2009 10:58:43 PM UTC, comment #1:

Thanks for the patch, but this is not the right solution.
Instead, you should add a service. Please check how, for
example, the routines for PFR data access are written. It
consists of ftpfr.c and ftpfr.h, defining the interface and
using a service, and svpfr.h and pfrdrivr.c, which implements
this service. Maybe it makes even sense to provide two
services, one for the static data and one for the parsing
functions, but this is a matter of taste and up to you.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Tue 17 Nov 2009 10:23:45 AM UTC, original submission:

I made some of FreeType's private cff calls public. I don't know what the policy is for this kind of thing. It would be nice if this could be integrated in the 'official' FT build as well (although not really required).

We need some of the predefined tables (charset/encoding) and we would like to parse a cff dict number ourselfs. The changes are attached as a patch.

bram tassyns <bramt>

 

Attached Files
file #22754:  cfftables.h added by bramt (3kB - text/plain)
file #22755:  cfftables.c added by bramt (8kB - text/plain)
file #22756:  diff of cffload.txt added by bramt (7kB - text/plain)
file #19074:  patch.txt added by bramt (6kB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by wl (Posted a comment)
  • -unavailable- added by bramt (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 21 Mar 2013 08:11:02 AM UTCwlStatusNeed Info=>Wont Do
      Open/ClosedOpen=>Closed
    Tue 22 Feb 2011 10:53:10 AM UTCbramtAttached File-=>Added cfftables.h, #22754
      Attached File-=>Added cfftables.c, #22755
      Attached File-=>Added diff of cffload.txt, #22756
    Sat 19 Feb 2011 06:17:26 AM UTCwlStatusIn Progress=>Need Info
    Wed 25 Nov 2009 10:58:43 PM UTCwlStatusNone=>In Progress
      Assigned toNone=>wl
    Tue 17 Nov 2009 10:23:45 AM UTCbramtAttached File-=>Added patch.txt, #19074

    Back to the top


    Powered by Savane 3.1-cleanup