patchWeeChat - Patches: patch #7972, weechat's icon is not being...

 
 

patch #7972: weechat's icon is not being installed via cmake

Submitted by:  None
Submitted on:  Tue 12 Mar 2013 08:53:14 PM UTC  
 
Category: packagingPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Sebastien Helleu <flashcode>Originator Email: -unavailable-
Open/Closed: ClosedIRC nick: tomboy64

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 10 Apr 2013 09:00:18 AM UTC, comment #2:

Hi,

I already committed your patch, but with changes, and I removed the line with @ONLY (not needed).

Please look at my commit, and tell me if there is a problem for you:
http://git.savannah.gnu.org/gitweb/?p=weechat.git;a=commitdiff;h=4b4d80b;hp=cac2342

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Mon 08 Apr 2013 11:06:28 PM UTC, comment #1:

my apologies; the provided patch contained an error which corrupts the installed icon with variable expansion. this version 2 replaces the @ONLY instruction with COPYONLY which should remedy this problem.

(file #27820)

Anonymous
Tue 12 Mar 2013 08:53:14 PM UTC, original submission:

This patch makes cmake install the (already provided) icon for weechat.
Please review whether the icon path is correct/sane - it seems to be for my Gentoo Linux distro.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #27820:  weechat-icon.patch added by None (1kB - text/x-patch - patch for CMakeLists.txt - version 2)
file #27599:  cmake_install_icon.patch added by None (1002B - text/x-patch - patch for CMakeLists.txt)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by flashcode (Updated the item)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 20 May 2013 09:10:54 AM UTCflashcodeOpen/ClosedOpen=>Closed
    Mon 08 Apr 2013 11:06:28 PM UTCNoneAttached File-=>Added weechat-icon.patch, #27820
    Sun 24 Mar 2013 09:24:32 AM UTCflashcodeStatusNone=>Done
      Assigned toNone=>flashcode
    Tue 12 Mar 2013 08:53:14 PM UTCNoneAttached File-=>Added cmake_install_icon.patch, #27599

    Back to the top


    Powered by Savane 3.1-cleanup