patchAVR Downloader/UploaDEr - Patches: patch #8436, Remove HAVE_STDINT_H guards in...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #8436: Remove HAVE_STDINT_H guards in flip1.c and flip2.c

Submitted by:  Rok Mandeljc <mrok>
Submitted on:  Thu 17 Apr 2014 11:40:48 AM UTC  
 
Category: NonePriority: 5 - Normal
Status: Need InfoPrivacy: Public
Assigned to: NoneOpen/Closed: Open

Tue 25 Nov 2014 08:16:44 PM UTC, comment #1:

I cannot confirm your statement #1: it compiles fine the way
it is in my MinGW32 cross-compilation environment.

Regarding reasoning #2, I don't see we are consistent in
either direction:

. libavrdude.h checks for HAVE_STDINT_H, and acts correctly
upon it
. fileio.c and ft245.c use <stdint.h> unchecked
. flip1/2 checks for either symbol, and acts upon it

IMHO, it would make most sense to remove all the checks
(including the one in libavrdude.h), and then assume <stdint.h>
always being present. AVRDUDE assumes a C99 compatible
environment in many other places already anyway.

Would you be willing to resubmit a patch that unifies it that
way?

Joerg Wunsch <joerg_wunsch>
Project Administrator
Thu 17 Apr 2014 11:40:48 AM UTC, original submission:

The attached patch removes HAVE_STDINT_H (and HAVE_INTTYPES_H) guards from flip1.c and flip2.c. The reason is two-fold:

a) HAVE_STDINT_H does not appear to be defined under MinGW*; consequently, stdint.h is not included, and compilation fails due to uint32_t being undefined

b) the rest of source files that include stdint.h do not use the guards, either

[*] using win-builds bundle 1.3.0 and msys (from MinGW-builds)

Rok Mandeljc <mrok>

 

Attached Files
file #31187:  stdint-fix.patch added by mrok (1kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by joerg_wunsch (Posted a comment)
  • -unavailable- added by mrok (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 25 Nov 2014 08:16:44 PM UTCjoerg_wunschStatusNone=>Need Info
    Thu 17 Apr 2014 11:40:48 AM UTCmrokAttached File-=>Added stdint-fix.patch, #31187

    Back to the top


    Powered by Savane 3.1-cleanup