maindavfs2 - Support: sr #107699, Reassigned to another tracker...

 
 

sr #107699: Reassigned to another tracker [was: too little space in additional header options]

Submitter:  None
Submitted:  Thu 26 May 2011 01:48:32 PM UTC
   
 
Category:  None Priority:  5 - Normal
Severity:  1 - Wish Status:  Confirmed
Privacy:  Public Assigned to:  _71007
Originator Email:  -email is unavailable- Open/Closed:  Closed
Operating System:  GNU/Linux
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 26 May 2011 08:53:59 PM UTC, comment #2: 

THIS ITEM WAS REASSIGNED TO BUG #33412


Please, do not post any new comments to this item.

- <_71007>
Thu 26 May 2011 08:51:22 PM UTC, comment #1: 

Thanks for the report and the patch.

Looks like I have created another example in the category
"How fixed size buffers that are meant to be much bigger than necessary turn out to be far to small."

I think I should drop that fixed size buffer alltogether and allocate the required space dynamically. Performance is of not of much concern at this point as the file is only parsed once.

I will move this report to the bug tracker so I will not forget about ist.

Occasionally other users have problems with Single Sign On and other cookie based authentication and more detailed information about how you solved the problem might be useful for them. As there is no better place at the moment, a report on this support tracker might be a good idea. But I should include it into the documentation some day.

Have you any idea how this could be integrated into davfs2?

Cheers
Werner

- <_71007>
Thu 26 May 2011 01:48:32 PM UTC, original submission:  

THIS ITEM WAS REASSIGNED TO BUG #33412
Hi.

We are using davfs2 to mount a share on an oracle server. The server needs a so called Single Sign On before the actual mount can be done.

The single sing on is done with a curl call to the server with some certificate and the result of this are some cookies, which need to be transmitted every time a request is made to the server.

The cookies are written into a davfs2.conf file as "add_header Cookie ..." lines, which is in turn then used by a call to mount.davfs2.

The problem here is, that davfs2 only accepts 253(?) bytes per line in a config file and the cookies are much longer. I patched it for me locally to accept more, but I'd like to know, if it would be possible to get longer lines in the upstream version, too. We now use 2048 byte in mount.davfs2.c ... but see this patch against 1.4.6 (from debian sid)

--- mount_davfs.c 2011-05-26 15:35:31.673037814 +0200
+++ mount_davfs.c_p 2011-05-26 15:35:18.740079775 +0200
@@ -1994,9 +1994,9 @@
 
     int state = SPACE;
     int parm_no = 0;
-    char buf[254];
+    char buf[2048];
     char *pos = buf;
-    char *end = buf + 253;
+    char *end = buf + 2047;
     char *p = line;
 
     while ((state != END) && (state != ERROR)) {

I would be very thankful, if this would get upstream, as I don't think it will harm anyone and it would rid me of taking care of patching newer versions as they come out.

Thanks and Regards
  Andre Naujoks

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by _71007 (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-05-26 _71007 Reassign Itemdavfs2, sr #107699 davfs2, bug #33412
    2011-05-26 _71007 StatusNone Confirmed
        Assigned toNone _71007

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code