mainSavannah Administration - Support: sr #108871, Gnash project's git mail...

 
 

sr #108871: Gnash project's git mail notification is giving out wrong repository URL

Submitter:  Nutchanon Wetchasit <nachanon>
Submitted:  Thu 20 Aug 2015 05:39:17 PM UTC
   
 
Category:  Project mailing lists Priority:  5 - Normal
Severity:  2 - Minor Status:  Done
Privacy:  Public Assigned to:  rwp
Operating System:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 09 Feb 2017 05:26:57 AM UTC, comment #5: 

Thanks for closure on this ticket.  I will mark it closed now.

Bob Proulx <rwp>
Site Administrator
Sat 04 Feb 2017 04:30:08 AM UTC, comment #4: 

I can confirm that Gnash Git commit notification email is now giving out a correct repository URL:
http://lists.gnu.org/archive/html/gnash-commit/2017-01/msg00037.html

The branch, master has been updated
       via  e90fc76cd653c5ecb481d845ae07c96715412443 (commit)
      from  49ad8249663616938ad34edf35825d93a31740ff (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/gnash.git/commit/?id=e90fc76cd653c5ecb481d845ae07c96715412443


commit e90fc76cd653c5ecb481d845ae07c96715412443
Author: Sandro Santilli <address@hidden>
Date:   Tue Jan 31 15:57:40 2017 +0100


Regarding the new Git email hook script: I'm neither a Gnash project administrator nor a project member, so decision to change or not to change is not mine, but is @rsavoye's (or @strk's). I'm just an external contributor.

As far as myself is concerned though, the problem is resolved; and I'm okay with current arrangement of Gnash project's commit notification.

This ticket could now be marked as Done.
Thanks.

Nutchanon Wetchasit <nachanon>
Tue 31 Jan 2017 12:13:51 AM UTC, comment #3: 

Oh wow. Sorry this is such an old bug ticket.

When I look at the commit hook setup I see it dates from Aug 5 2010. I see it has the buggy post-receive.d setup that many had and still have. (At some point I need to go through the entire list of all git repositories and fix any that are bad. Details available if you ask on the mailing list.) I fixed that for this project.

As for the documentation you have cited and all of the references you included let me say I am very impressed!  You found files that I didn't even know existed.

However I think this is really the documentation you wanted to find:

http://savannah.gnu.org/maintenance/Git/

And this is the live repository for looking at the current config file contents.

http://git.savannah.gnu.org/r/gnash.git/

There has been some development in the years since 2010 when this was set up.  We are now recommending using the https://github.com/mhagger/git-multimail notification script.  Would you like to try it?  You can see the new format in some of the other lists such as http://lists.gnu.org/archive/html/emacs-diffs/2017-01/threads.html here.

However as for your current git hook I think you are absolutely correct with your bug finding. I added "gnash.git" in the place you indicated with ${dir_git} that was, as you surmised, almost certainly not getting set.  (I will do a grep and look for other configs that might also be broken in this way.)

Thank you for being so persistent with this ticket. I made the change you found to be needed. Please look at the next commit and see if this is fixed now.

Bob Proulx <rwp>
Site Administrator
Mon 30 Jan 2017 04:53:10 PM UTC, comment #2: 

After digging around the source code, I figured this problem might be related to these lines in Savannah administration sheet:

mkdir -m 755 $GIT_DIR/hooks/post-receive.d
chattr +i $GIT_DIR/hooks
ln -s /usr/src/git/contrib/hooks/post-receive-email $GIT_DIR/hooks/post-receive.d/
git config hooks.showrev "t=%s; echo http://git.savannah.gnu.org/cgit/${dir_git}/commit/?id=\$t; echo; echo; git show -C \$t; echo"
git config hooks.mailinglist $project-commit@xgnu.org
popd


You would see that the `hooks.showrev` line is using `${dir_git}` variable for repository name. This variable is not assigned from anywhere in the sheet, so I suspected that the correct one is actually `${GIT_DIR}` (which should be "gnash.git" in case of Gnash project).

See also: Git post-receive-email documentation

Fixing this in existing Git repositories would involve manual editing of Git's `hooks.showrev` configuration property to add the repository name in; which definitely require Savannah staff's intervention.

Nutchanon Wetchasit <nachanon>
Mon 30 Jan 2017 04:45:57 PM UTC, comment #1: 

This problem is still reproducible, see this email:
https://lists.gnu.org/archive/html/gnash-commit/2017-01/msg00030.html

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=37044f9ef5888401b2cfc83df8ae0ceeef6bd37c


commit 37044f9ef5888401b2cfc83df8ae0ceeef6bd37c
Author: Sandro Santilli <address@hidden>
Date:   Mon Jan 30 09:13:44 2017 +0100


From the email, you would see that repository name is still missing from the link:
http://git.savannah.gnu.org/cgit//commit/?id=37044f9ef5888401b2cfc83df8ae0ceeef6bd37c

The correct link should be:
http://git.savannah.gnu.org/cgit/gnash.git/commit/?id=37044f9ef5888401b2cfc83df8ae0ceeef6bd37c

Nutchanon Wetchasit <nachanon>
Thu 20 Aug 2015 05:39:17 PM UTC, original submission:  

Not sure if this problem is specific to Gnash project or not,
but it seems to be infrastructure-related, so I decided to post here.

I've been reading some recent git-generated mail on Gnash project's gnash-commit list archive:
http://lists.gnu.org/archive/html/gnash-commit/2015-08/msg00043.html

On the email, there is a link to the corresponding git commit, which shown like this:
http://git.savannah.gnu.org/cgit//commit/?id=88f86a3c63171283388f3644008763f2e6ab851b

But this URL is wrong (gives HTTP 404) as repository name part is missing.
The correct one should be like this:
http://git.savannah.gnu.org/cgit/gnash.git/commit/?id=88f86a3c63171283388f3644008763f2e6ab851b

Please fix.
Thanks.

Nutchanon Wetchasit <nachanon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rwp (Posted a comment)
  • -email is unavailable- added by nachanon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-02-09 rwp StatusIn Progress Done
        Open/ClosedOpen Closed
    2017-01-31 rwp StatusNone In Progress
        Assigned toNone rwp

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code