helpTraverso: A Multitrack Audio Recorder and Editor - Support: sr #109677, two compile question: sqrtf64()...

 
 

sr #109677: two compile question: sqrtf64() and Q_WS_XXX macro

Submitted by:  Renzhi Shi <skyfe>
Submitted on:  Sun 05 May 2019 06:25:19 AM UTC  
 
Category:  None Priority:  5 - Normal
Severity:  3 - Normal Status:  Ready For Test
Privacy:  Public Assigned to:  Remon Sijrier <r_sijrier>
Open/Closed:  Open Operating System:  None

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Mon 06 May 2019 09:37:37 AM UTC, comment #6: 

Merged the patch upstream including fix for compile error in FileHelpers

Remon Sijrier <r_sijrier>
Project AdministratorIn charge of this item.
Mon 06 May 2019 08:41:19 AM UTC, comment #5: 

Thanks for the patch.

It seems at some point I messed up the indentation, in the patch there are really a lot of indentation ' fixes ' which makes the patch hard to read.

The PERROR I changed recently but due the nature of the Q_WS_XXX macro not being valid the code was never compiled so I did not catch I forgot some PERROR. changed that in git.

Seems a couple of bug reports actually relate to this so in fact this is an important find and closes some bug reports as well, thanks!

Remon Sijrier <r_sijrier>
Project AdministratorIn charge of this item.
Mon 06 May 2019 04:46:03 AM UTC, comment #4: 

I noticed the PERROR macro in sources, if we pass 2 arguments it will causes a compilation error(like src/core/FileHelpers.cpp, line 103).
Just comment it out or changed it to PERROR2?
Thanks

Renzhi Shi <skyfe>
Sun 05 May 2019 08:41:18 PM UTC, comment #3: 

You can attach the file with the 'Attached Files' section below the Discussion section of this page or send the patch directly to me by email  ( remon at traverso-daw dot org )

Remon Sijrier <r_sijrier>
Project AdministratorIn charge of this item.
Sun 05 May 2019 06:49:03 PM UTC, comment #2: 

Hello, Mr Sijrier. I have made changes in source files and prepared a patch. Then how I submit it? Any guidelines? Thanks.

Renzhi Shi <skyfe>
Sun 05 May 2019 11:06:33 AM UTC, comment #1: 

Hello Shi,

Seems port to Qt5 isn't complete after all :)

The Q_WS_XXX indeed need to be replaced with Q_OS_MACOS

Ideally one would look by a per case basis if an operating specific check is still needed or if a common solution for all operating systems can be used for that case.

Since I do not have a MacOS, patches are gladly accepted.

The sqrtf64 was recently committed to git, but I cannot find any documentation either so I reverted it back to sqrtf.
The author of the CorrelationMeter used double for precision in that particular calculation but used sqrtf (float precision), could ask him if the reduced precision is a problem or not.

Thanks for reporting!

Remon Sijrier <r_sijrier>
Project AdministratorIn charge of this item.
Sun 05 May 2019 06:25:19 AM UTC, original submission:  

Hello,I have compiled the traverso on Centos7 and Win10 with Qt5.12.2.

I encounter two problem during compilation:
1. The compiler complained "‘sqrtf64’ was not declared in this scope", and I have to change it to 'sqrtf' to continute compiling. Where can I find the definition of 'sqrtf64'?

2. Q_WS_XXX macro in Qt5 be replaced by Q_OS_XXX. Does it need to be modified?

Thanks

Renzhi Shi <skyfe>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #46867:  0001-change-all-Q_WS_XXX-macro-to-Qt5-style.patch added by skyfe (116KiB - application/octet-stream - Just simple change all the Q_WS_XXX type macro.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by r_sijrier (Posted a comment)
  • -email is unavailable- added by skyfe (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-05-06 skyfe Attached File- => Added 0001-change-all-Q_WS_XXX-macro-to-Qt5-style.patch, #46867
    2019-05-05 r_sijrier StatusNone => Ready For Test
        Assigned toNone => r_sijrier

    Back to the top


    Powered by Savane 3.5