mainTutka - Support: sr #110180, tutka sometimes crash when...

 
 

sr #110180: tutka sometimes crash when exporting a MIDI file after song has been played.

Submitter:  None
Submitted:  Tue 21 Jan 2020 03:00:07 PM UTC
   
 
Category:  None Priority:  5 - Normal
Severity:  3 - Normal Status:  None
Privacy:  Public Assigned to:  None
Originator Email:  -email is unavailable- Open/Closed:  Open
Operating System:  * GNU/Linux
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 21 Jan 2020 03:00:07 PM UTC, original submission:  

Tracing with gdb shows me it tries to delete oldSong in line 1084 of player.cpp (Player::init). However, this particular player object is created by conversion.cpp songToSMF at line 572.

Looking into Player constructor that gets used for this call (player.cpp line 72), I can see that oldSong is not initialised; thus the crash.

My simple fix: just make sure that oldSong is set NULL too in this constructor.

diff -ur tutka-1.1.3/src/player.cpp tutka-1.1.3-new/src/player.cpp
--- tutka-1.1.3/src/player.cpp 2019-08-06 05:00:43.000000000 +1000
+++ tutka-1.1.3-new/src/player.cpp 2020-01-22 00:37:07.887603529 +1000
@@ -78,6 +78,7 @@
     line_(0),
     tick(0),
     song(song),
+    oldSong(NULL),
     mode_(ModeIdle),
     scheduler(NULL),
     syncMode(Off),


However this seems to have a side-effect that all the instruments in the currently playing song will lose its MIDI output and has to be re-assigned again if you want to hear anything. I don't know how to fix this, but I suppose it still better than a total crash and losing the song altogether.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    No changes have been made to this item

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code