helpLet me illustrate... - Support: sr #104430, Enable menu items and toolbar...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

sr #104430: Enable menu items and toolbar buttons consistently

Submitted by:  Greg Chicares <chicares>
Submitted on:  Thu 14 Jul 2005 01:08:45 PM UTC  
 
Category: GUIStatus: Ready For Test
Priority: 7 - HighSeverity: 4 - Important
Assigned to: Vadim Zeitlin <zeitlin>Open/Closed: Open

Tue 23 Mar 2010 04:53:58 PM UTC, comment #2:

The example from the original bug report seems to work fine now (i.e. with wx 2.9 and latest LMI sources from svn) and, AFAICS, this is implemented by IllustrationView::UponUpdateProperties() in illustration_view.cpp, i.e. exactly as it was supposed to.

Are there other known examples where this doesn't work as expected?

Vadim Zeitlin <zeitlin>
Project MemberIn charge of this item.
Sun 02 Oct 2005 11:01:59 PM UTC, comment #1:

Need to check whether EVT_UPDATE_UI works as expected with doc/view menus: in response to my suggestion to just use it, Greg wrote:

<blockquote>
I've tried that. There are inline comments like this:

// Needed for (xrc) menu enablement: a
// EVT_UPDATE_UI(XRCID("wxID_SAVE"),lmi_wx_app::OnUpdateFileSave)
// handler fails to update enablement for that menu item.
// However, enablement of an item with the same ID on the
// toolbar apparently requires the EVT_UPDATE_UI technique.
wxDocument* doc = doc_manager_->GetCurrentDocument();
wxMenuItem* file_save = child_frame->GetMenuBar()->FindItem
(XRCID("wxID_SAVE")
);
if(file_save)
{
file_save->Enable(doc && doc->IsModified());
}

But I find no overall description of the problem, like a scientist's lab
notes that record experiments so as to make them easily reproducible,
accompanied by observations that others can validate or falsify. I could
write such a description if it's not immediately apparent to you what
I've done wrong.

I think I suspected some subtle interaction between doc-view default
processing and wxxrc, but my recollection is not clear.

</blockquote>

Vadim Zeitlin <zeitlin>
Project MemberIn charge of this item.
Thu 14 Jul 2005 01:08:45 PM UTC, original submission:

For the nonce, certain commands that don't make sense in context
produce pop-up warnings; instead, the applicable GUI elements
should be disabled when it would be senseless to use them.

Example:
File | New | Census
Census | Run selected cell
Illustration | Edit cell
In this context, 'Edit cell' should be inhibited.

Greg Chicares <chicares>
Project Administrator

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue 23 Mar 2010 04:53:58 PM UTCzeitlinStatusNone=>Ready For Test
Wed 27 Sep 2006 01:34:19 PM UTCchicaresPriority5 - Normal=>7 - High
Thu 27 Apr 2006 07:52:35 PM UTCwboutinCategoryNone=>GUI
Sun 02 Oct 2005 11:01:59 PM UTCzeitlinAssigned toNone=>zeitlin

Back to the top


Powered by Savane 3.1-cleanup