lwIP - A Lightweight TCP/IP stack - Tasks: task #11493, PPP - change static buffers to...
You are not allowed to post comments on this tracker with your current authentication level.
task #11493: PPP - change static buffers to PBUFs
Submitter: | Ivan Delamer <idelamer> | ||
Submitted: | Wed 26 Oct 2011 09:48:18 PM UTC | ||
Category: | Network drivers | Should Start On: | Wed 26 Oct 2011 06:00:00 AM UTC |
Should be Finished on: | Fri 26 Oct 2012 06:00:00 AM UTC | Priority: | 5 - Normal |
Status: | None | Privacy: | Public |
Assigned to: | None | Percent Complete: | 0% |
Open/Closed: | Closed | Planned Release: | None |
Effort: | 0.00 |
Jump to the original submission
Tue 03 Jul 2012 08:33:45 PM UTC, comment #6: |
Ivan Delamer <idelamer> |
Tue 13 Mar 2012 04:38:42 PM UTC, comment #5: I don't think this should gate 1.4.1 |
Kieran Mansley <kieranm> |
Tue 01 Nov 2011 09:04:49 PM UTC, comment #4: Seems to me like keeping the original samba PPP code was a good initial choice. However, I think that the way it is written is very un-LwIP-esque. Memory use (program, bss and data) is large compared to other parts of LwIP. I need about an extra 20K flash and 7K RAM.
|
Ivan Delamer <idelamer> |
Tue 01 Nov 2011 11:32:27 AM UTC, comment #3: When Doping so, please keep in mind that most of the PPP code is deliberately left unchanged to the original samba PPP code. Pbufs are only used in ppp.c (which is a replacement for the main file in the original PPP, which is OS-dependent there). |
Simon Goldschmidt <goldsimon> |
Mon 31 Oct 2011 04:38:40 PM UTC, comment #2: That's right...
|
Ivan Delamer <idelamer> |
Sat 29 Oct 2011 08:09:37 PM UTC, comment #1: What about the "while (l)" at the top of lcp_reqci()? I haven't really used PPP other than playing around with it a bit, but from reading the code, a peer could send multiple CIs that are all NAK'ed so we could have x times a NAK. |
Simon Goldschmidt <goldsimon> |
Wed 26 Oct 2011 09:48:18 PM UTC, original submission:
I'll be working with PPP so I may be posting some patches or tasks. I won't push any commits until I receive some feedback or get proficient enough in PPP to do so.
|
Ivan Delamer <idelamer> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2012-07-03 | idelamer | Open/Closed | Open | Closed | |
2012-07-03 | idelamer | Carbon-Copy | Removed 11869 | - | |
2012-07-03 | idelamer | Carbon-Copy | Removed 42414 | - | |
2012-03-13 | kieranm | Planned Release | 1.4.1 | None | |
2011-10-31 | idelamer | Summary | PPP - lcp.c nak_buffer is too large | PPP - change static buffers to PBUFs |
Powered by Savane 3.13-d3ae.
Corresponding source code
done in branch ppp-new