taskMapOSMatic - Tasks: task #11708, Render quotes in index as...

 
 

task #11708: Render quotes in index as typographic quotes

Submitter:  Eric Marsden <emarsden>
Submitted:  Sun 01 Jan 2012 01:11:34 PM UTC
   
 
Should Start On:  Sat 18 Feb 2012 08:00:00 AM UTC Should be Finished on:  Sat 18 Feb 2012 08:00:00 AM UTC
Category:  None Priority:  * 1 - Later
Status:  Invalid Privacy:  Public
Assigned to:  None Percent Complete:  0%
Open/Closed:  Closed Release:  None
Effort:  0.00
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 18 Feb 2012 06:57:20 PM UTC, comment #5: 

I agree with David Decotigny's comment here. We shouldn't touch the data, it has always been our policy.

Maxime Petazzoni <mpetazzoni>
Group administrator
Sun 01 Jan 2012 01:11:34 PM UTC, comment #4: 

This item has been reassigned from the project MapOSMatic bugs tracker to your tracker.

The original report is still available at bugs #30647

Following are the information included in the original report:

[field #0]                  Item ID: 30647
[field #1]                 Group ID: 10335
[field #2]              Open/Closed: Open
[field #3]                 Severity: 2 - Minor
[field #4]                  Privacy: Public
[field #8]                         : Unknown bugs Field Display Type
[field #9]                 Category: ocitysmap
[field #10]             Submitted by: emarsden
[field #11]              Assigned to: None
[field #12]             Submitted on: mer. 04 août 2010 15:29:07 CEST
[field #13]                  Summary: Render quotes in index as typographic quotes
[field #14]      Original Submission: Suggestion: quote characters in street names would be prettier if rendered in the index as typographic quotes instead of straight ASCII quotes. This may seem to be contrary to your "don't modify OSM data" dogma, but the difference between an ordinary quote and a typographic quote character is in presentation, not in semantics.

See attached patch.
[field #16]               Item Group: None
[field #17]                   Status: Postponed
[field #18]        Component Version: None
[field #19]         Operating System: None
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 1 - Later
[field #31]         Percent Complete: 0%
[field #33]                  Release: None
[field #58]     Custom Select Box #1: None
[field #59]     Custom Select Box #2: None
[field #60]     Custom Select Box #3: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

David Mentré <dmentre>
Group administrator
Tue 02 Nov 2010 09:09:18 AM UTC, comment #3: 

Technically possible, but I don't think maposmatic/ocitysmap2 would be the right place to do it. Incorrect/ill-formatted information should be fixed at the source, that's one thing openstreetmap is good at.

David Decotigny <daviddecotigny>
Group administrator
Mon 23 Aug 2010 08:17:32 AM UTC, comment #2: 

IMHO, the rendering code is not the place to make such changes, especially since it may not apply to all languages. It should be done in the data retreival for the index, and passed through a function of one of i18n's subclasses.

Maxime Petazzoni <mpetazzoni>
Group administrator
Mon 23 Aug 2010 07:42:30 AM UTC, comment #1: 

My opinion: I agree that we could change some OSM data to make them prettier on the map. However, after a quick glance at the proposed patch, I fear it would risk to change data in an uncontrolled way, as we don't know all the rules in all languages used by OSM.

One proposal would be to match on longer prefixes, e.g. L'.

David Mentré <dmentre>
Group administrator
Sun 01 Jan 2012 01:11:34 PM UTC, original submission:  

Suggestion: quote characters in street names would be prettier if rendered in the index as typographic quotes instead of straight ASCII quotes. This may seem to be contrary to your "don't modify OSM data" dogma, but the difference between an ordinary quote and a typographic quote character is in presentation, not in semantics.

See attached patch.

Eric Marsden <emarsden>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #21137:  ocity-typographic.diff added by emarsden (524B - text/x-patch - PATCH: suggested implementation)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by daviddecotigny (Posted a comment)
  • -email is unavailable- added by mpetazzoni (Posted a comment)
  • -email is unavailable- added by dmentre (Posted a comment)
  • -email is unavailable- added by emarsden (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-02-18 mpetazzoni Should Start On- 2012-02-18
        Should be Finished on- 2012-02-18
        StatusNone Invalid
        Open/ClosedOpen Closed
    2012-01-01 dmentre Reassign itemMapOSMatic, bug #30647 MapOSMatic, task #11708

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code