taskLINGOT Is Not a Guitar-Only Tuner - Tasks: task #12463, Make the default audio system...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #12463: Make the default audio system configurable

Submitted by:  Ibán Cereijo <ibancereijo>
Submitted on:  Sat 02 Feb 2013 02:45:27 PM UTC  
 
Should Start On: Sat 02 Feb 2013 12:00:00 AM UTCShould be Finished on: Sat 02 Feb 2013 12:00:00 AM UTC
Category: NonePriority: 5 - Normal
Status: Ready For TestPrivacy: Public
Percent Complete: 0%Assigned to: Ibán Cereijo <ibancereijo>
Open/Closed: OpenEffort: 0.00

Mon 04 Feb 2013 10:51:34 PM UTC, comment #1:

It is enough now to add one of the following preprocessor symbols:

DEFAULT_AUDIO_SYSTEM_OSS
DEFAULT_AUDIO_SYSTEM_JACK
DEFAULT_AUDIO_SYSTEM_PULSEAUDIO

The default when none of them is added is still ALSA

Example:

> export CFLAGS=-DDEFAULT_AUDIO_SYSTEM_PULSEAUDIO
> ./configure
> make

Ibán Cereijo <ibancereijo>
Project AdministratorIn charge of this item.
Sat 02 Feb 2013 02:45:27 PM UTC, original submission:

original suggestion by Karel Volný:

- and last one, not connected to translations but to packaging, wouldn't that
be possible to make the default audio system configurable, so that it can be
changed without patching the sources?

I can imagine (not tried in reality yet) that something like this could work:

--- lingot-config.c~ 2013-01-29 02:10:08.000000000 +0100
+++ lingot-config.c 2013-02-01 17:41:18.417624288 +0100
@@ -185,7 +185,11 @@

void lingot_config_restore_default_values(LingotConfig* config) {

+#ifdef DEFAULT_AUDIO_SYSTEM
+ config->audio_system = DEFAULT_AUDIO_SYSTEM;
+#else
config->audio_system = AUDIO_SYSTEM_ALSA;
+#elif
sprintf(config->audio_dev[AUDIO_SYSTEM_OSS], "%s", "/dev/dsp");
sprintf(config->audio_dev[AUDIO_SYSTEM_ALSA], "%s", "default");
sprintf(config->audio_dev[AUDIO_SYSTEM_JACK], "%s", "default");

then I would add
"-D DEFAULT_AUDIO_SYSTEM=AUDIO_SYSTEM_PULSEAUDIO"
to CFLAGS to change to Fedora's prefered PA ...?

(well, I'm not a PA advocate, but with ALSA we're hitting bug
https://bugzilla.redhat.com/show_bug.cgi?id=600751 while it seems to work with
PA ... to be precise, with the new betaversion of 0.9.2 on Fedora 18, I
managed to get it working even with ALSA, but then it goes nuts once I start
messing with the device selection)

Ibán Cereijo <ibancereijo>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by ibancereijo (Submitted the item)
  • -unavailable- added by ibancereijo
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 04 Feb 2013 10:51:34 PM UTCibancereijoStatusNone=>Ready For Test
      Assigned toNone=>ibancereijo
    Sat 02 Feb 2013 02:45:27 PM UTCibancereijoCarbon-Copy-=>Added

    Back to the top


    Powered by Savane 3.1-cleanup1