tasklwIP - A Lightweight TCP/IP stack - Tasks: task #14282, Add FreeRTOS port

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #14282: Add FreeRTOS port

Submitted by:  Simon Goldschmidt <goldsimon>
Submitted on:  Tue 20 Dec 2016 07:51:53 AM UTC  
 
Category:  None Should Start On:  Tue 20 Dec 2016 12:00:00 AM UTC
Should be Finished on:  Tue 20 Dec 2016 12:00:00 AM UTC Priority:  5 - Normal
Status:  Done Privacy:  Public
Percent Complete:  100% Assigned to:  Simon Goldschmidt <goldsimon>
Open/Closed:  Closed Planned Release:  2.1.0
Effort:  99.99

( Jump to the original submission)

Thu 04 Jan 2018 08:35:12 AM UTC, comment #7:

Ah right, I misinterpreted that. Good that the default is OFF then, I had been wondering about that before!

Daniel Elstner <danielk>
Thu 04 Jan 2018 07:31:56 AM UTC, comment #6:

> I see that you introduced a separate lwIP configuration define
> for using FreeRTOS mutexes, any reason not to use the FreeRTOS
> config itself here?


That define makes SYS_ARCH_PROTECT lock interrupts vs. get a global mutex. That's not a question of FreeRTOS config but a question of what the user wants (and probably a question of performance, too). Maybe the name could be changed to better reflect this ;-)

The sanity checks are a good idea, though.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 04 Jan 2018 07:03:19 AM UTC, comment #5:

Hey, cool that this went in. I just had a quick glance over your code. I see that you introduced a separate lwIP configuration define for using FreeRTOS mutexes, any reason not to use the FreeRTOS config itself here? Also, some sanity checking of the FreeRTOS config could help to avoid problems, in particular the INCLUDE_vTaskSuspend is needed or pdMAX_DELAY won't work.

Daniel Elstner <danielk>
Thu 04 Jan 2018 06:06:06 AM UTC, comment #4:

> Sorry Daniel. I missed your posts here. Plus I can't find it...


Haha, didn't see that 'github' was a link :-)

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Wed 03 Jan 2018 09:27:36 PM UTC, comment #3:

Sorry Daniel. I missed your posts here. Plus I can't find it...

Anyway, I've committed my own work of last year. This one keeps the FreeRTOS includes in sys_arch.c for now (so the FreeRTOS headers won't get included in all files including lwIP sys.h).

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Fri 20 Jan 2017 12:26:38 AM UTC, comment #2:

Here it is, on github.

I've removed any non-generic bits, made it conform with C89, and changed the indentation to 2 spaces. The copyright notice is copied from other lwIP files.

Daniel Elstner <danielk>
Thu 19 Jan 2017 07:49:01 PM UTC, comment #1:

I have a FreeRTOS port ready which I could contribute. Specifically, it makes use of FreeRTOS mutexes, which many of the templates out there don't.

Daniel Elstner <danielk>
Tue 20 Dec 2016 07:51:53 AM UTC, original submission:

As this seems to be one of the most used OSes with lwIP, I'm willing to add this as supported port by now. After all, it will be good to have an actual example of a non-simulation port (up to now, we only have unix and win32 ports in contrib).

However, this will still need some weeks, I guess...

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by danielk (Posted a comment)
  • -email is unavailable- added by goldsimon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    Wed 03 Jan 2018 09:27:36 PM UTC goldsimon StatusNone => Done
        Percent Complete0% => 100%
        Open/ClosedOpen => Closed
        Planned ReleaseNone => 2.1.0
    Wed 26 Jul 2017 08:19:04 PM UTC goldsimon StatusIn Progress => None
    Tue 28 Feb 2017 08:35:36 PM UTC goldsimon Planned Release2.0.2 => None

    Back to the top


    Powered by Savane 3.3