taskSavannah Administration - Tasks: task #14414, Submission of GNUstep Non-FSF

 
 

task #14414: Submission of GNUstep Non-FSF

Submitter:  Adam Fedor <fedor>
Submitted:  Sat 18 Mar 2017 07:09:33 PM UTC
   
 
Should Start On:  Sat 18 Mar 2017 06:00:00 AM UTC Should be Finished on:  Tue 28 Mar 2017 06:00:00 AM UTC
Category:  Project Approval Priority:  * 5 - Normal
Status:  Done Privacy:  Public
Assigned to:  ineiev Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Fri 14 Jul 2017 03:30:06 PM UTC, comment #26: 
Riccardo Mottola <rmottola>
Thu 13 Jul 2017 06:18:36 PM UTC, comment #25: 

Thank you, approving.

Ineiev <ineiev>
Site Administrator
Wed 12 Jul 2017 11:59:38 AM UTC, comment #24: 

GNA died and there were no backups - we didn't work it out in time, this introduced some delays. I hope I have restored the repository without loosing changes.

We removed the "Face" code. Tracking a current email address of the original author proved difficult, but the feature is not very relevant, so we simplified by removing the x-face extension.

I added specific entries for the "script" files as well as the project files.
Also, I specified the relevant files in all READMEs of the languages resources.

(file #41188)

Riccardo Mottola <rmottola>
Sat 13 May 2017 09:41:10 PM UTC, comment #23: 

If you can rewrite or avoid whatever is in that file, clearly that would be best from a licensing point of view.

Failing that, my only idea is to ask -email is unavailable- if it can be allowed as an exception. Given the date, maybe, but it's not up to us.

Best,
Karl

Karl Berry <karl>
Site Administrator
Sat 13 May 2017 09:29:19 PM UTC, comment #22: 

let me skip for now to the other thing you mentioned:

>Bundles/Face/Face.h has a confusing statement:


>// This code has been created by Carl Edman <cedman@capitalist.princeton.edu>
>// (C) Copyright 1995, but otherwise this file is perfect freeware.
>
>Could you clarify the status of that file? Generally, "freeware" is proprietary software.


What are you asking me to do? Actually, what do you propose to do?
I cannot "clarify" the status of a file written 22 years ago by somebody I do not know: written before all this license fuss. What do you propose to do? It is clearly code adapted again and again.

Before doing any other work or discussion on notices about other files, I'll wait for something reasonable to discuss about.
Remove the notice? Lie and relicense? drop that software part? stop pursuing any acceptanse of GNUMail into savannah.gnu.org ? any proposed alternatives for a different software repository?

Riccardo Mottola <rmottola>
Mon 08 May 2017 11:57:21 AM UTC, comment #21: 

Thank you!

I still can't find copyright and license notices for files like
GNUMail.suiteModel and GNUMail.scriptSuite.

Files like Resources/Russian.lproj/README don't list the files
they apply to.

Bundles/Face/Face.h has a confusing statement:

// This code has been created by Carl Edman <cedman@capitalist.princeton.edu>
// (C) Copyright 1995, but otherwise this file is perfect freeware.

Could you clarify the status of that file? Generally, "freeware" is proprietary software.

Ineiev <ineiev>
Site Administrator
Sun 07 May 2017 12:36:30 PM UTC, comment #20: 


>Are you saying they are not parts of your source code? Then why not remove them?


They are interface description files, they are necessary for the application to run. What I mean is that the containing directory should not have extra files like READMEs.

>> The README file is in this case in Resources/English.lproj/


>These files only contain copyright and license notices, they don't say what files they apply to. I believe this is necessary.


I added for each directory the list of .nib/.gorm subdirectories to and a note that it applies to all their content too.

I did further cleanup. Backup files are not part of the SVN repository nor they are released, it may happen since I do quick local tarballs to share with you.

(file #40610)

Riccardo Mottola <rmottola>
Tue 02 May 2017 07:27:50 AM UTC, comment #19: 

Thank you for fixing IMAGES_README!

> .gorm and .nib files are actually bundles, thus what counts is
> the directory containing those files, which are under program
> control and should not contain extraneous files (an editor might
> remove them on a open/save cycle or possible give an error).


Are you saying they are not parts of your source code?  Then why not remove them?

> The README file is in this case in Resources/English.lproj/


These files only contain copyright and license notices, they don't say what files they apply to.  I believe this is necessary.

Bundles/Account/English.proj has no such README at all.

Also, please remove (supposedly) backup files like Documentation/IMAGES_README~.

Ineiev <ineiev>
Site Administrator
Mon 01 May 2017 02:29:51 PM UTC, comment #18: 


> It looks like Documentation/IMAGES_README has a few typos,

these files are missing:

Indeed there were some case-issues, typos and other minor things that I amended.
I made all licenses explicit too.

> Files like Bundles/Compose/English.lproj/ComposeView.nib/info.nib

and Bundles/Compose/English.lproj/ComposeView.nib/classes.nib still
have no copyright and license notices.

That's intended and will stay such: .gorm and .nib files are actually bundles, thus what counts is the directory containing those files, which are under program control and should not contain extraneous files (an editor might remove them on a open/save cycle or possible give an error).
The README file is in this case in Resources/English.lproj/


On a bundle-aware file manager as GNU's GWorkspace or Apple's Finder, you will see them as a single object.

(file #40544)

Riccardo Mottola <rmottola>
Mon 01 May 2017 06:01:43 AM UTC, comment #17: 

Thank you!

Please note that my point was not how you could or couldn't split
a copyright notice, but whether what you split was a valid
copyright notice in the first place.

It looks like Documentation/IMAGES_README has a few typos,
these files are missing:

Bundles/Face/stamp.tiff
Bundles/Sending/English.lproj/SendingView.nib/delete_20.tiff
Bundles/Sending/MailIcon_send.tiff
Bundles/PGP/pgp-mail.tiff
Bundles/PGP/signed+encrypted_80.tiff
Bundles/Fonts/fonts.tiff

...and the tarball doesn't contain these files listed in it:

Bundles/Faces/stamp.tiff
Bundles/Fonts/Fonts.tiff
Bundles/PGP/signe+encrypted_80.tiff
Bundles/Receiving/MailIcon_send.tiff

Also, I recommend adding a full licensing notice for these files
to Documentation/IMAGES_README, not just saying "GPLv2 or later";
and the file is non-trivial, it should have a copyright and licensing
notices for itself.

Files like Bundles/Compose/English.lproj/ComposeView.nib/info.nib
and Bundles/Compose/English.lproj/ComposeView.nib/classes.nib still
have no copyright and license notices.

Ineiev <ineiev>
Site Administrator
Sun 30 Apr 2017 06:39:04 AM UTC, comment #16: 

Discussing if and how a Copyright can be split on several lines is sterile. I think I am right, since it can be split on more lines, without explicitly requiring that each line is a valid copyright. Discussing a "copyright grammar" here is however useless.
Said that, I attempted to comply.

To attack the images problem instead, I made a single documentation file: Documentation/IMAGES_README

This file contains the different images citing original author and license, to the best I could track down.

(file #40538)

Riccardo Mottola <rmottola>
Tue 25 Apr 2017 06:23:29 PM UTC, comment #15: 


> What would be invalid in that copyright line? Even the guide you cite states that copyrights can be split over multiple lines if too long


It states copyright line can be split (for example, if there are many years). The copyright notice still should look like "Copyright (C) year1, year2, year3 copyright-holder".

>Copyright (C) x1-x2 Author 1
> x3-x4 Author 2


(Please note that authors are not relevant, it's copyright holders that matter.)

The page I mentioned explains that if there are multiple copyright holders, you can include copyright notices for other holders (it doesn't say you could include other copyright holders in the same notice).

Bundles/Clock/*.tiff don't seem to have copyright and license notices.

Even image files and sound files should contain copyright notices and license notices, if their format permits. Some formats do not have room for textual annotations; for these files, state the copyright and copying permissions in a README file in the same directory.


Ineiev <ineiev>
Site Administrator
Tue 25 Apr 2017 10:51:40 AM UTC, comment #14: 

Hi all,
All addresses are now fixed: either by replacing the address or by using the URL reference. I grepped through all files, source files, Makefiles, READMEs.

What would be invalid in that copyright line? Even the guide you cite states that copyrights can be split over multiple lines if too long.

Copyright (C) x1-x2 Author 1
              x3-x4 Author 2

is clear and leaves no doubt that the line is just split on multiple lines, it is common practice too.
Also, all headers of this project are done this way (and of many other projects I work with, as a note).

I'd leave it as-is. Or did I misinterpret your issue?

We do have a deadline, it would be about "now" since GNA is closing down and we don't know how many days are left. Things are starting to malfunction already.

I Attach a new tarball with the amended addresses and references.

(file #40498)

Riccardo Mottola <rmottola>
Mon 24 Apr 2017 10:09:46 PM UTC, comment #13: 

The English word "Copyright" is all that matters. The ASCII "(C)" or "(c)" is harmless but irrelevant.

Karl Berry <karl>
Site Administrator
Mon 24 Apr 2017 10:07:39 AM UTC, comment #12: 

Thank you!

The second line in README still doesn't form a valid copyright notice, it lacks the "Copyright (C)" part.

In files like Bundle/Clock/ClockController.h, FSF's address is twice outdated; I recommend using the URL like the GPL HowTo suggests.

There are still files like Documentation/PREFERENCES that lack valid copyright notices.

By the way, have you any deadline for this approval process?  If the tarball be fixed one file a day, it may last two years.

Ineiev <ineiev>
Site Administrator
Sun 23 Apr 2017 11:50:35 AM UTC, comment #11: 

Thanks - I checked your feedback.

I did not attach the wrong wile, but I unfortunately missed a lot of files, Mac and GNUstep builds use a different subset files in their projects, but of course we need them all

1) I amended the copyright notice in the remaining files, I hope this time for them to be really all
2) I fixed the XPM copyright too. I corrected the Author&License, but not the format of (C).
3) I added the LGPLv2 license notice inside Documentation
4) fixed a couple of other missing notices and old addresses in the Makefiles
5) I find it acceptable to put the copyright&license at the bottom of the ChangeLog files as in the example you showed, thus I updated them, including the older ones.

I hope nothing else is missing?

Riccardo Mottola <rmottola>
Sun 23 Apr 2017 05:55:10 AM UTC, comment #10: 


> I went through all copyright notices of all source files, they had the same issues as the Readme file. I amended that.
> Furthermore, the copyright and license attribution of the icon was wrong. I fixed that.


Thank you!

The copyright notice in GNUMail.xpm ("Copyright (C) 2000") is still invalid,
please check https://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html

Also, the second line in README doesn't form a valid copyright notice, it lacks the "Copyright (C)" part.

If you distribute some files under the LGPL, you should include a copy of that license in your tarball; you don't (please note that you may redistribute LGPLed works under the ordinary GPL, but then you should update the license notice in those files).

> However, let's be reasonable: inserting a copyright and license statement in a ChangeLog file is absurd, I have never seen that


(Warning: that some of these pages are about 1Mbyte long)
https://git.savannah.gnu.org/cgit/emacs.git/tree/ChangeLog.1
https://bitbucket.org/skypher/fdisk/src/94911b8cfd93cf8226584135fb9d753ab7582ded/ChangeLog?at=default
http://git.savannah.gnu.org/cgit/bison.git/tree/ChangeLog-2012
http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=ChangeLog;h=e555d07f67840cdd1ec6dcdba2bbf708daeb883c;hb=HEAD
https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=blob;f=ChangeLog-2011;h=01601fa61cb496ce343dd45848e20e590702d944;hb=HEAD

I don't see why it is absurd.  The texts of changelogs are copyrightable, and if I redistribute copyrightable texts without explicit permission, I technically violate copyright; if I technically violate copyright, under some regimes I can end up in jail.

Do you want your users to be imprisoned?

> and the file needs to be essentially machine-creatable from the SVN commits. It holds no further information and is not a support file to the project.


Then you can just omit it.  If some tools require a file named ChangeLog, you can add a non-copyrightable stub directing to VCS.

Now. All files should have valid copyright and license notices.  Files like Bundles/Clock/ClockController.h don't.

I wonder if you attached a wrong file.

Ineiev <ineiev>
Site Administrator
Fri 21 Apr 2017 07:41:04 PM UTC, comment #9: 

I went through all copyright notices of all source files, they had the same issues as the Readme file. I amended that.
Furthermore, the copyright and license attribution of the icon was wrong. I fixed that.

However, let's be reasonable: inserting a copyright and license statement in a ChangeLog file is absurd, I have never seen that and the file needs to be essentially machine-creatable from the SVN commits. It holds no further information and is not a support file to the project.
Thus I added only a notice for it in the README file and the same follows for the plist files.

New tarball attached.

Riccardo Mottola <rmottola>
Tue 18 Apr 2017 07:14:05 AM UTC, comment #8: 

All files should have valid copyright and license notices.  The copyright notices you've added to Documentation/README and GNUMail.xpm are not valid; please check https://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html for the correct format of copyright notices.

Also, some files like ChangeLog still have no license and copyright notices.  Please check all files in your tarball.

Ineiev <ineiev>
Site Administrator
Tue 18 Apr 2017 02:17:17 AM UTC, comment #7: 

OK I added an update gnumail-3.tar.gz

(file #40432)

Adam Fedor <fedor>
Tue 11 Apr 2017 03:15:41 PM UTC, comment #6: 

Thank you!

All files should have valid copyright and license notices, including files like Documentation/README and images like GNUMail.xpm.

Also, FSF's address in your notices is twice outdated; I'd recommend using an URL, like GPL HowTo suggests.

Ineiev <ineiev>
Site Administrator
Mon 10 Apr 2017 01:41:54 PM UTC, comment #5: 

I attached a distribution of the app

Adam Fedor <fedor>
Tue 04 Apr 2017 06:45:17 AM UTC, comment #4: 

Thank you!

Could you provide a distribution tarball instead of repository dump? This would make the evaluation much easier.

Ineiev <ineiev>
Site Administrator
Mon 03 Apr 2017 07:00:51 PM UTC, comment #3: 

I've uploaded a new SVN dump

http://ftp.gnustep.org/pub/gnustep/contrib/gnustep-nonfsf-1.dump.gz

We've put copyright notices in ever place possible according to the rules.  If there is still something missing it would be nice to know specifically what items are missing

Adam Fedor <fedor>
Fri 31 Mar 2017 02:34:16 PM UTC, comment #2: 

If there is no interest, I'll cancel this submission.

Ineiev <ineiev>
Site Administrator
Sun 19 Mar 2017 11:11:04 AM UTC, comment #1: 

All files in the package should have valid copyright and license notices.

Please check https://savannah.gnu.org/maintenance/ValidNotices/

Ineiev <ineiev>
Site Administrator
Sat 18 Mar 2017 07:09:33 PM UTC, original submission:  

A new project has been registered at Savannah
This project account will remain inactive until a site admin approves or discards the registration.


Registration Administration


While this item will be useful to track the registration process, approving or discarding the registration must be done using the specific Group Administration page, accessible only to site administrators, effectively logged as site administrators (superuser):



Registration Details


  • Name: GNUstep Non-FSF
  • System Name:  gnustep-nonfsf
  • Type: non-GNU software and documentation
  • License: GNU General Public License v2 or later (GNUstep Non-FSF programs have similar licenses to the GNUstep project, but have copyrights that are help by their respective authors instead of the FSF.)





Description:

This project contains a collection of applications, libraries and tools that are based on the GNUstep project. This includes a Code editor, Mail application and extra GNUstep themes.


Other Software Required:

None


Other Comments:

The project is transitioning from being hosted at gna.org as that site is shutting down. Upload contains an SVN dump, which needs to be restored (via 'svnadmin load').


Tarball URL:

http://ftp.gnustep.org/pub/gnustep/contrib/gnustep-nonfsf.dump.gz


Adam Fedor <fedor>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #41188:  GNUMail-10.tar.gz added by rmottola (1MiB - application/gzip)
file #40610:  GNUMail-9.tar.gz added by rmottola (1MiB - application/gzip)
file #40544:  GNUMail-8.tar.gz added by rmottola (1MiB - application/gzip)
file #40538:  GNUMail-7.tar.gz added by rmottola (1MiB - application/gzip)
file #40498:  GNUMail-6.tar.gz added by rmottola (1MiB - application/gzip)
file #40497:  GNUMail-6.tar.gz added by rmottola (1MiB - application/gzip)
file #40476:  GNUMail_5.tar.gz added by rmottola (1MiB - application/gzip)
file #40470:  GNUMail-4.tar.gz added by rmottola (1MiB - application/gzip)
file #40432:  gnumail-3.tar.gz added by fedor (1MiB - application/x-gzip)
file #40348:  gnumail-2.tar.gz added by fedor (1MiB - application/x-gzip - Here's a distribution of the app)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by karl (Posted a comment)
  • -email is unavailable- added by rmottola (Posted a comment)
  • -email is unavailable- added by ineiev (Posted a comment)
  • -email is unavailable- added by fedor (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 14 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-07-13 ineiev StatusIn Progress Done
        Open/ClosedOpen Closed
    2017-07-12 rmottola Attached File- Added GNUMail-10.tar.gz, #41188
    2017-05-07 rmottola Attached File- Added GNUMail-9.tar.gz, #40610
    2017-05-01 rmottola Attached File- Added GNUMail-8.tar.gz, #40544
    2017-04-30 rmottola Attached File- Added GNUMail-7.tar.gz, #40538
    2017-04-25 rmottola Attached File- Added GNUMail-6.tar.gz, #40498
    2017-04-25 rmottola Attached File- Added GNUMail-6.tar.gz, #40497
    2017-04-23 rmottola Attached File- Added GNUMail_5.tar.gz, #40476
    2017-04-21 rmottola Attached File- Added GNUMail-4.tar.gz, #40470
    2017-04-18 fedor Attached File- Added gnumail-3.tar.gz, #40432
    2017-04-10 fedor Attached File- Added gnumail-2.tar.gz, #40348
    2017-03-19 ineiev StatusNone In Progress
        Assigned toNone ineiev

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code