tasklwIP - A Lightweight TCP/IP stack - Tasks: task #14433, TCP: combine unsent/unacked queue...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #14433: TCP: combine unsent/unacked queue loops in tcp_receive()

Submitter:  Joel Cunningham <jcunningham>
Submitted:  Wed 29 Mar 2017 09:36:50 PM UTC
   
 
Category:  TCP Should Start On:  Wed 29 Mar 2017 12:00:00 AM UTC
Should be Finished on:  Wed 29 Mar 2017 12:00:00 AM UTC Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Percent Complete:  100%
Open/Closed:  Closed Planned Release:  None
Effort:  0.00

Wed 03 May 2017 02:33:06 PM UTC, comment #2: 

I reviewed the changes, great improvement :)  I found one minor indentation issue from the leftover TCP_OVERSIZE block and have fixed it in ddf4e174113d99268da9ee2633eefd79ae8d82c3

Joel Cunningham <jcunningham>
Group Member
Wed 03 May 2017 10:33:00 AM UTC, comment #1: 

I've just pushed this. I haven't found other occurrences of duplicated loops.

Simon Goldschmidt <goldsimon>
Group administrator
Wed 29 Mar 2017 09:36:50 PM UTC, original submission:  

As identified in bug #50614, we can combine the unsent/unacked queue processing loops into a single generalized loop, eliminating duplicated code

Assigning to myself for now, I'll take a pass at it when time permits

It may be worth it to also audit how the queues are looped over in other places in the TCP code to see if there is other duplicate loops

Joel Cunningham <jcunningham>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by jcunningham (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-05-03 goldsimon StatusNone Done
        Percent Complete0% 100%
        Assigned tojcunningham goldsimon
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code