tasklwIP - A Lightweight TCP/IP stack - Tasks: task #14523, Add core locking support to...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #14523: Add core locking support to netconn_gethostbyname

Submitter:  Joel Cunningham <jcunningham>
Submitted:  Wed 24 May 2017 10:47:08 PM UTC
   
 
Category:  DNS Should Start On:  Wed 24 May 2017 12:00:00 AM UTC
Should be Finished on:  Wed 24 May 2017 12:00:00 AM UTC Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  jcunningham Percent Complete:  100%
Open/Closed:  Closed Planned Release:  None
Effort:  0.00

Jump to the original submission

Wed 05 Jul 2017 10:21:27 PM UTC, comment #7: 

Shell 'gethostnm' command added to lwip-contrib in 950dd357e0ad4ce40a893f98c4e94486d15c6cf6

Joel Cunningham <jcunningham>
Group Member
Tue 20 Jun 2017 10:57:41 PM UTC, comment #6: 

Simon,

I have committed the patch in d4c8a1ac78024d25ea75dcb193988d1f668feb8c.  I tested both core locking and non-core locking cases.

I'll also push a change to lwip-contrib which adds a shell command allowing easy testing of netconn_gethostbyname().  I'm away from my computer that has this patch, so it'll be next week before I can submit that.  Leaving at 90% so I don't forget the lwip-contrib change

Joel Cunningham <jcunningham>
Group Member
Tue 20 Jun 2017 06:31:33 PM UTC, comment #5: 

Finally found the time. Sorry for taking so long, unfortunately, I don't find much time for lwIP lately.

The patch looks fine! This is from reading only, I haven't tested it...

Simon Goldschmidt <goldsimon>
Group administrator
Fri 16 Jun 2017 02:50:38 PM UTC, comment #4: 

Ping!

Anyone get a chance to look at my patch yet?

Thanks

Joel Cunningham <jcunningham>
Group Member
Sat 03 Jun 2017 06:30:50 AM UTC, comment #3: 

Attached patch switches to using tcpip_send_msg_wait_sem() which abstracts core locking vs non-core locking.

Change turned out pretty simple and I was able to follow how netconn_write_partly/lwip_netconn_do_write works for blocking in the core locking case when needing to wait for asynchronous completion.

Would appreciate a code review when you have a chance

Also, I created a shell command to exercise netconn_gethostbyname.  I can push this as well

(file #40847)

Joel Cunningham <jcunningham>
Group Member
Wed 31 May 2017 03:29:32 PM UTC, comment #2: 

Simon,

I don't have a patch yet, but I might be able to get to it this week

Joel Cunningham <jcunningham>
Group Member
Mon 29 May 2017 07:03:05 PM UTC, comment #1: 

Right. I wasn't aware of that. Just go ahead if you have code ready :-)

> This would be a performance improvement and moves us closer to a future with only core locking :)


That's the plan...

Simon Goldschmidt <goldsimon>
Group administrator
Wed 24 May 2017 10:47:08 PM UTC, original submission:  

lwip_netconn_do_gethostbyname() is still being executed via tcpip_callback which means that we aren't using core locking even when LWIP_TCPIP_CORE_LOCKING is 1

This would be a performance improvement and moves us closer to a future with only core locking :)

Joel Cunningham <jcunningham>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by jcunningham (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-07-05 jcunningham StatusIn Progress Done
        Percent Complete90% 100%
        Open/ClosedOpen Closed
    2017-06-20 jcunningham Percent Complete0% 90%
    2017-06-03 jcunningham Attached File- Added 0001-netconn-switch-gethostbyname-to-use-tcpip_send_msg_w.patch, #40847
    2017-06-01 jcunningham StatusNone In Progress
        Assigned toNone jcunningham

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code