tasklwIP - A Lightweight TCP/IP stack - Tasks: task #14597, cleanup pbuf_header usages

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #14597: cleanup pbuf_header usages

Submitter:  Simon Goldschmidt <goldsimon>
Submitted:  Fri 04 Aug 2017 11:19:36 AM UTC
   
 
Category:  pbufs Should Start On:  Fri 04 Aug 2017 12:00:00 AM UTC
Should be Finished on:  Fri 04 Aug 2017 12:00:00 AM UTC Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Percent Complete:  100%
Open/Closed:  Closed Planned Release:  None
Effort:  0.00

Mon 21 Aug 2017 08:37:13 PM UTC, comment #1: 

Should be done now.

Simon Goldschmidt <goldsimon>
Group administrator
Fri 04 Aug 2017 11:19:36 AM UTC, original submission:  

I've just split pbuf_header(s16_t) into pbuf_add_header(size_t) and pbuf_remove_header(size_t)

The new functions both take size_t as increment/decrement argument instead of s16_t (which needed to be range-checked before conversion everywhere) - in most places, the direction (increment or decrement) is known anyway, so no need to encode it in a sign bit.

Next step is to udpate all stack-internal usages of pbuf_header (where appropriate - i.e. where the direction is known and the increment value is not already an s16_t).

pbuf_header() will of course remain working for compatibility.

Simon Goldschmidt <goldsimon>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-08-21 goldsimon StatusIn Progress Done
        Percent Complete90% 100%
        Open/ClosedOpen Closed
    2017-08-04 goldsimon Percent Complete30% 90%

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code