tasklwIP - A Lightweight TCP/IP stack - Tasks: task #14780, Add debug helper asserts to ensure...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #14780: Add debug helper asserts to ensure threading/locking requirements are met

Submitted by:  Simon Goldschmidt <goldsimon>
Submitted on:  Thu 21 Dec 2017 05:52:01 AM UTC  
 
Category:  None Should Start On:  Thu 21 Dec 2017 12:00:00 AM UTC
Should be Finished on:  Thu 21 Dec 2017 12:00:00 AM UTC Priority:  5 - Normal
Status:  Done Privacy:  Public
Percent Complete:  100% Assigned to:  Simon Goldschmidt <goldsimon>
Open/Closed:  Closed Planned Release:  2.1.0
Effort:  0.00

Sun 04 Feb 2018 12:37:48 PM UTC, comment #4: 

After adding a little more documentation and adding an example for non-ISR check in contrib/ports/freertos, I think I'm OK with this as it is now.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Sat 03 Feb 2018 09:14:41 PM UTC, comment #3: 

I've just done PPP. Anything more? I don't think so...

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Wed 10 Jan 2018 02:30:29 PM UTC, comment #2: 

TODO:

- add locking check macro in more places
- do something for NO_SYS=1

Dirk Ziegelmeier <dziegel>
Project Administrator
Tue 02 Jan 2018 10:00:31 AM UTC, comment #1: 

Thank you for creating a task for this. Here's a suggestion to start the discussion:

  • Add ASSERT_CORE_LOCKED
  • define it empty by default
  • Leave it to the arch specific code to implement. Some might want to support recursive calls so use a counter, others just a binary flag. Some might just use a static flag that is set after locking and cleared before unlocking. Some might have an OS function to check if the lock is held and use that.
  • Many implementations will probably not enforce this assertion for a start. But it should help to document what is expected for thread safety.
Douglas <ourairquality>
Thu 21 Dec 2017 05:52:01 AM UTC, original submission:  
Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dziegel (Posted a comment)
  • -email is unavailable- added by ourairquality (Posted a comment)
  • -email is unavailable- added by goldsimon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-02-04 goldsimon StatusNone => Done
        Percent Complete90% => 100%
        Open/ClosedOpen => Closed
    2018-02-03 goldsimon Percent Complete50% => 90%
    2018-01-03 goldsimon Percent Complete0% => 50%
    2018-01-02 goldsimon Planned ReleaseNone => 2.1.0

    Back to the top


    Powered by Savane 3.5