taskSavannah Administration - Tasks: task #15352, Submission of An interpretor for a...

 
 

task #15352: Submission of An interpretor for a language with automatic error propagation

Submitted by:  Sanjay <sanb>
Submitted on:  Tue 30 Jul 2019 08:32:30 PM UTC  
 
Should Start On:  Tue 30 Jul 2019 12:00:00 AM UTC Should be Finished on:  Fri 09 Aug 2019 12:00:00 AM UTC
Category:  Project Approval Priority:  5 - Normal
Status:  Done Privacy:  Public
Percent Complete:  0% Assigned to:  Ineiev <ineiev>
Open/Closed:  Closed Effort:  0.00

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Tue 03 Sep 2019 01:57:40 AM UTC, comment #21: 

comment #20:

> Thank you, approving.


Thank you.  Thanks for all the help.

Sanjay <sanb>
Sun 01 Sep 2019 12:58:01 PM UTC, comment #20: 

Thank you, approving.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Thu 29 Aug 2019 09:58:48 PM UTC, comment #19: 

comment #18:

> > > > No.  There aren't any files with wrong copyright notices in this package.
> > >
> > > Why?
> >
> > What do you mean?
>
> We discovered one file with a wrong copyright notice, so at that point, it was possible that some files had wrong copyright notices.
>
> I'd like to know why this is not the case now.


Oh.  Because I have now manually checked, to the best of my ability, every file packaged in the fussy.tar.gz file for the copyright notice and that is the correct one. 

Sanjay <sanb>
Thu 29 Aug 2019 01:56:25 PM UTC, comment #18: 

> > > No.  There aren't any files with wrong copyright notices in this package.
> >
> > Why?
>
> What do you mean?


We discovered one file with a wrong copyright notice, so at that point, it was possible that some files had wrong copyright notices.

I'd like to know why this is not the case now.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Tue 27 Aug 2019 08:51:09 PM UTC, comment #17: 

comment #16:

> > I have now added the required README file.
>
> Thank you! README doesn't explicitly list the files the notices apply to;
> this is quite easy to get wrong, by just adding a new file with a different
> status; could you fix that?


Done.  The README file explicitly also lists the files the notices apply to.

> > I have modified the
> > scripts that generates them to include copyright and license notices in them
> > when they are generated.  These files are not in fussy.tar.gz.
>
> Then why not include them?  GNU standards say that such files should be included.


OK.  I have no problem in including them -- they have the notices anyway (as you point out).  They are now included in the fussy.tar.gz file.

>
> >> I should ask if there are other such files with wrong copyright notices
> >> in your package.
> > No.  There aren't any files with wrong copyright notices in this package.
>
> Why?


What do you mean?

I have updated the fussy.tar.gz file at http://www.aoc.nrao.edu/~sbhatnag/Softwares/fussy.tar.gz.  Could you review it again?

Thanks for your help so far.

Sanjay <sanb>
Mon 26 Aug 2019 08:11:37 AM UTC, comment #16: 

> I have now added the required README file.


Thank you! README doesn't explicitly list the files the notices apply to;
this is quite easy to get wrong, by just adding a new file with a different
status; could you fix that?

> src/*.a files are not part of the code repository for this project any more
> and are therefore also not part of the tar file.


It does't follow for me.  Making a release is more than just bundling up your
source files in a tar file and putting it up for FTP.

> While I do not understand
> why these files would require any notice whatsoever,


They require notices because they are copyrightable.

> I have modified the
> scripts that generates them to include copyright and license notices in them
> when they are generated.  These files are not in fussy.tar.gz.


Then why not include them?  GNU standards say that such files should be included.

>> I should ask if there are other such files with wrong copyright notices
>> in your package.
> No.  There aren't any files with wrong copyright notices in this package.


Why?

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Wed 21 Aug 2019 08:49:59 PM UTC, comment #15: 

Kindly review the updated fussy.tar.gz file at http://www.aoc.nrao.edu/~sbhatnag/Softwares/fussy.tar.gz.  Thanks.

Comments answers to your questions earlier are below.

comment #13:

> > > Files like lex.yy.c and src/vm.a have no copyright and license notices (please check other files as well).
> >
> > We have removed these files.   These are not necessary and are generated as part of the build process.  Apologies for missing to exclude them earlier.
>
> This case is harder than removing files like 'configure': you'll need to re-add them and  ensure their compliance  when your package is evaluated for GNU ('configure' already was compliant).


src/*.a files are not part of the code repository for this project any more and are therefore also not part of the tar file.  While I do not understand why these files would require any notice whatsoever, I have modified the scripts that generates them to include copyright and license notices in them when they are generated.  These files are not in fussy.tar.gz. 

>
> > We have checked that all files now have some copyright and license notice.  Only files which have neither are the following PDF files.  Not sure if they need these notices and if so, how to add them.
> >
> > doc/LaTeX/Figs/fig1.pdf
> > doc/LaTeX/Figs/fig2.pdf
>
> https://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html says that if some file has a format that doesn't permit notices, they should be stated in a README file in the same directory.  Haven't you read that page?


I have.  But misunderstood requirement for files like the .pdf files mentioned above.  I have now added the required README file.

comment #14:

> > Thanks for pointing this out.  We have now removed our copyright notice from it
>
> Oh, and of course, now I should ask if there are other such files with wrong copyright notices in your package.


No.  There aren't any files with wrong copyright notices in this package.

Sanjay <sanb>
Sun 18 Aug 2019 05:27:20 PM UTC, comment #14: 

> Thanks for pointing this out.  We have now removed our copyright notice from it


Oh, and of course, now I should ask if there are other such files with wrong copyright notices in your package.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Sun 18 Aug 2019 05:20:18 PM UTC, comment #13: 

> Thanks for pointing this out.  We have now removed our copyright notice from it, but kept the license notice.  Hope that is appropriate (and necessary?).


It already had a permissive license notice; you can add the notice from the GPL on top of it, but it isn't necessary.

> > Files like lex.yy.c and src/vm.a have no copyright and license notices (please check other files as well).
>
> We have removed these files.   These are not necessary and are generated as part of the build process.  Apologies for missing to exclude them earlier.


This case is harder than removing files like 'configure': you'll need to re-add them and  ensure their compliance  when your package is evaluated for GNU ('configure' already was compliant).

> We have checked that all files now have some copyright and license notice.  Only files which have neither are the following PDF files.  Not sure if they need these notices and if so, how to add them.
>
> doc/LaTeX/Figs/fig1.pdf
> doc/LaTeX/Figs/fig2.pdf


https://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html says that if some file has a format that doesn't permit notices, they should be stated in a README file in the same directory.  Haven't you read that page?

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Thu 15 Aug 2019 08:43:07 PM UTC, comment #12: 

comment #11:

Could we request you to re-check the updated tar file (http://www.aoc.nrao.edu/~sbhatnag/Softwares/fussy.tar.gz)?

Thanks for your continued effort in reviewing our submission.  Apologies for missing the issues you mention below:

> INSTALL looks like the file from Autoconf; have you any copyright related to it, really?


Thanks for pointing this out.  We have now removed our copyright notice from it, but kept the license notice.  Hope that is appropriate (and necessary?).

> Files like lex.yy.c and src/vm.a have no copyright and license notices (please check other files as well).


We have removed these files.   These are not necessary and are generated as part of the build process.  Apologies for missing to exclude them earlier.

We have checked that all files now have some copyright and license notice.  Only files which have neither are the following PDF files.  Not sure if they need these notices and if so, how to add them.

doc/LaTeX/Figs/fig1.pdf
doc/LaTeX/Figs/fig2.pdf

> At last, some of your license notices say, "Foobar is distributed in the hope that it will be useful".


Fixed.  "grep -ir foobar *" now does not find any file.  Apologies for missing to check this earlier.

>
> > As a separate question: Is there an existing script/program
> > that one can use to ensure compliance of the source code
> > with Savannah requirements?
>
> No.  There used to be an alpha-quality script, but we check packages manually these days.  It shouldn't be a problem for your package, it has less than 1000 files.


Thanks.  A combination of the "find" and "grep" commands to search for a few keywords seems to be sufficient for this project.

Sanjay <sanb>
Thu 15 Aug 2019 09:51:37 AM UTC, comment #11: 

> Could you please check the source files again (http://www.aoc.nrao.edu/~sbhatnag/Softwares/fussy.tar.gz)?
> AFAICT, all files have the copyright notices, we have updated
> all copyright notices to be same (GPLv3+) and the form of the
> notice is as advised by you.


Thank you!

INSTALL looks like the file from Autoconf; have you any copyright related to it, really?

Files like lex.yy.c and src/vm.a have no copyright and license notices (please check other files as well).

At last, some of your license notices say, "Foobar is distributed in the hope that it will be useful".

> As a separate question: Is there an existing script/program
> that one can use to ensure compliance of the source code
> with Savannah requirements?


No.  There used to be an alpha-quality script, but we check packages manually these days.  It shouldn't be a problem for your package, it has less than 1000 files.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Tue 13 Aug 2019 04:32:56 PM UTC, comment #10: 

comment #9:

> > We are working separately to comply with GNU standards before it can be accepted as a GNU Project.
> ...
> > Let us know if this is OK. I.e. get the various legal notices etc. right to make it a Savannah project first, without changing how we currently build the project.
>
> It's up to you.  Let us to that separately.


Could you please check the source files again (http://www.aoc.nrao.edu/~sbhatnag/Softwares/fussy.tar.gz)? AFAICT, all files have the copyright notices, we have updated all copyright notices to be same (GPLv3+) and the form of the notice is as advised by you.

We have also included ./configure and associated files now.  Those of course can also be re-build by running the "./build" script.

As a separate question: Is there an existing script/program that one can use to ensure compliance of the source code with Savannah requirements?

Sanjay <sanb>
Wed 07 Aug 2019 02:29:50 AM UTC, comment #9: 

> We are working separately to comply with GNU standards before it can be accepted as a GNU Project.

...

> Let us know if this is OK. I.e. get the various legal notices etc. right to make it a Savannah project first, without changing how we currently build the project.


It's up to you.  Let us to that separately.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Tue 06 Aug 2019 05:38:05 PM UTC, comment #8: 

comment #7:

>
> Savannah has no requirements about building the package from the source code; but you applied for inclusion in the GNU Project, so you still should comply with GNU Standards.


We are working separately to comply with GNU standards before it can be accepted as a GNU Project.  There are other things in the code that need change to comply with GNU standards.  Also we still don't know if it will even be accepted as a GNU Project. 

Therefore we would like to start using Savannah as our git repos first and do the development required on this repos to comply for acceptance as a GNU Project. Hence the current effort to do whatever is needed to comply with Savannah requirements. 

Let us know if this is OK. I.e. get the various legal notices etc. right to make it a Savannah project first, without changing how we currently build the project.

Sanjay <sanb>
Tue 06 Aug 2019 04:41:18 PM UTC, comment #7: 

> This isn't "wrong" since the software currently builds by running the "build" script which is included in the tar file.  This, as you can see, generates the "configure" file.  Currently this is our preferred mode of building the software.  I hope Savannah does not impose restrictions on how to build the program from the source code.


Savannah has no requirements about building the package from the source code; but you applied for inclusion in the GNU Project, so you still should comply with GNU Standards.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Tue 06 Aug 2019 04:12:31 PM UTC, comment #6: 

comment #5:

> Files like .gitignore and src/exit.dat still have no notices; also, many files in your tarball say they are GPLv2+ rather than GPLv3+, and have an obsolete address of the FSF. I recommend using the form of the notice from the GPL HowTo.


OK.  We will modify the notices accordingly and make a modified tar file later today.

>
> > Others have been excluded in the tar.gz file.
>
> As far as I can see, you excluded files like 'configure'.  This is wrong, because your package needs them.


This isn't "wrong" since the software currently builds by running the "build" script which is included in the tar file.  This, as you can see, generates the "configure" file.  Currently this is our preferred mode of building the software.  I hope Savannah does not impose restrictions on how to build the program from the source code.

Sanjay <sanb>
Mon 05 Aug 2019 11:43:10 AM UTC, comment #5: 

Files like .gitignore and src/exit.dat still have no notices; also, many files in your tarball say they are GPLv2+ rather than GPLv3+, and have an obsolete address of the FSF. I recommend using the form of the notice from the GPL HowTo.

> Others have been excluded in the tar.gz file.


As far as I can see, you excluded files like 'configure'.  This is wrong, because your package needs them.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Thu 01 Aug 2019 03:44:16 PM UTC, comment #4: 

comment #3:

> > I haven't added these notices to files which are generated (as against written by us).
>
> I think Information for maintainers of GNU software doesn't distinguish between "written" and "generated" files.


OK. Check again the tar file: http://www.aoc.nrao.edu/~sbhatnag/Softwares/fussy.tar.gz.  All copyrightable files should have notices.  Others have been excluded in the tar.gz file.

Sanjay <sanb>
Thu 01 Aug 2019 09:43:40 AM UTC, comment #3: 

> I haven't added these notices to files which are generated (as against written by us).


I think Information for maintainers of GNU software doesn't distinguish between "written" and "generated" files.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Wed 31 Jul 2019 03:00:19 PM UTC, comment #2: 

comment #1:

> Please make sure that all copyrightable files in your tarball have valid copyright and license notices.  Currently, README has neither.


I am added copyright and license headers in all files I think are copyrightable.  This includes README, README.md, TODO, NOTES and a few other files.  I haven't added these notices to files which are generated (as against written by us).  Hope this is sufficient.

The changes are in http://www.aoc.nrao.edu/~sbhatnag/Softwares/fussy.tar.gz.  I am also attempting to attach this file with this task (not quite sure I know how to do it yet though).

Sanjay <sanb>
Wed 31 Jul 2019 10:26:20 AM UTC, comment #1: 

Please make sure that all copyrightable files in your tarball have valid copyright and license notices.  Currently, README has neither.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Tue 30 Jul 2019 08:32:30 PM UTC, original submission:  

A new project has been registered at Savannah
This project account will remain inactive until a site admin approves
or discards the registration.

Registration Administration

While this item will be useful to track the registration process,
approving or discarding the registration must be done using the specific Group Administration page, accessible only to site administrators,
effectively logged as site administrators (superuser):

Registration Details

  • Name: An interpretor for a language with automatic error propagation
  • System Name:  fussy
  • Type: non-GNU software and documentation
  • License: GNU General Public License v3 or later

Description:

The fussy program implements a scripting language with an algorithm for automatic error propagation of random measurement errors in an arbitrary mathematical expression. The program can be used as a simple interactive calculator with error propagation. Mathematical expressions can be implemented as a collection of sub-expressions, as sub-program units (functions or procedures) or as single atomic expressions. Sub-expressions can be assigned to temporary variables which can then be used to write the final expression. The interpreter is internally implemented as a virtual machine for efficient runtime performance and can be used as an interpreter in a client code as well. A simple C binding to the interpreter is also provided.

The scripting syntax of fussy is similar to that of C programming language. It is easy, particularly for those familiar with programming in C, to use fussy with minimal learning. In its simplest form, fussy interpretor can be used interactively as a simple calculator with the added feature of automatic error prorogation (see syntax for simple expressions, sub-expressions, and functions/procedure).

Other Comments:

The code depends only on libraries and tools available on standard  GNU/Linux system.

We currently host the project on GitHub:

https://github.com/sanbee/fussy

Tarball URL:

http://www.aoc.nrao.edu/~sbhatnag/Softwares/fussy.tar.gz

Sanjay <sanb>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ineiev (Posted a comment)
  • -email is unavailable- added by sanb (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-09-01 ineiev StatusIn Progress => Done
        Open/ClosedOpen => Closed
    2019-08-06 ineiev Should Start On2019-08-05 => 2019-07-30
        Should be Finished on2019-08-05 => 2019-08-09
    2019-08-05 ineiev Should Start On2019-08-01 => 2019-08-05
        Should be Finished on2019-08-01 => 2019-08-05
    2019-08-01 ineiev Should Start On2019-07-30 => 2019-08-01
        Should be Finished on2019-08-09 => 2019-08-01
    2019-07-31 ineiev StatusNone => In Progress
        Assigned toNone => ineiev

    Back to the top


    Powered by Savane 3.5