Ive made a small patch for rss feeds, so shell:// style urls can be used.

I wanted this so I could get broken rss feeds, and fix them up with xmllint first.

There are of course pros and cons to this.
Pro:
- mldonkey dont need to deal with each and every brokeness out there. feed them first through xmllint or whatever
- rss feeds can be synthesized from web pages( i have a couple of these already)

Con:
- maybe opens new security holes

The cons could be handled the same way as for the "!" command(my patch currently doesnt). Pango has a pach for a security enhanced "!" command, which could be refactored to be used with this shell:// extension. The idea is that this extension wont cause more trouble than the existing "!" command, if done properly.

here is what the patch looks like:

in commonweb:

rename mldonkey_wget to mldonkey_wget_url

let mldonkey_wget_shell url f =                                                                                                                                                                                                                                                    
  let command_urlencoded = Str.string_after url 8 in                                                                                                                                                                                                                               
  let command = Url.decode command_urlencoded in                                                                                                                                                                                                                                   
  let filename = "/tmp/crapname.out" in                                                                                                                                                                                                                                            
    Sys.command (Printf.sprintf "%s > %s" command filename);                                                                                                                                                                                                                       
    (f filename : unit)                                                                                                                                                                                                                                                            
      ( wget does something like this at the end: (f filename : unit); )                                                                                                                                                                                                         
                                                                                                                                                                                                                                                                                   
                                                                                                                                                                                                                                                                                   
let mldonkey_wget url f =                                                                                                                                                                                                                                                          
  if Str.string_match (Str.regexp "shell://") url 0 then                                                                                                                                                                                                                           
    mldonkey_wget_shell url f                                                                                                                                                                                                                                                      
  else                                                                                                                                                                                                                                                                             
    mldonkey_wget_url url f


a testcase:
urladd rss shell:///tmp/rsscommand%2520http%253A//thepiratebay.org/rss.php%253Fcat%253D601

where rsscommand looks like:

curl $1|xmllint -