taskmldonkey, a multi-networks file-sharing client - Tasks: task #8478, Reassigned to another tracker...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #8478: Reassigned to another tracker [was: Mail: Move hostname from subject to body]

Submitted by:  daniel <eydaimon>
Submitted on:  Fri 08 Aug 2008 10:01:02 AM UTC  
 
Category:  Core Priority:  5 - Normal
Status:  None Assigned to:  None
Open/Closed:  Closed Should Start On:  Fri 08 Aug 2008 12:00:00 AM UTC
Should be Finished on:  Fri 08 Aug 2008 12:00:00 AM UTC

Mon 01 Sep 2008 07:35:39 AM UTC, comment #4: 

THIS ITEM WAS REASSIGNED TO PATCH #6629


Please, do not post any new comments to this item.

spiralvoice <spiralvoice>
Project Administrator
Fri 08 Aug 2008 02:30:04 PM UTC, comment #3: 

Here's a patch with the host in the body instead.

FYI, I didn't submit the original patch with the task because I hadn't actually planned making one ;)

Index: commonInteractive.ml
===================================================================
RCS file: /sources/mldonkey/mldonkey/src/daemon/common/commonInteractive.ml,v
retrieving revision 1.105
diff -r1.105 commonInteractive.ml
346c346
<         Printf.sprintf "[mldonkey@%s] file received - %s" (Unix.gethostname ()) (file_best_name file)
---

>         Printf.sprintf "mldonkey - %s complete." (file_best_name file)

348c348
<         Printf.sprintf "mldonkey@%s, file received" (Unix.gethostname ())
---

>         Printf.sprintf "mldonkey - download complete."

368c368
<       Printf.sprintf "\r\nUser/Group: %s:%s\r\n" (file_owner file).user_name (user2_print_group (file_group file))
---

>       Printf.sprintf "\r\nUser/Group: %s:%s" (file_owner file).user_name (user2_print_group (file_group file))

370c370,374
<
---

>
>     let line7 =
>       Printf.sprintf "\r\nServer Host: %s\r\n" (Unix.gethostname ())
>     in
>

376c380
<         M.mail_body = line1 ^ line2 ^ line3 ^ line4 ^ line5 ^ (if admin then line6 else "");
---

>         M.mail_body = line1 ^ line2 ^ line3 ^ line4 ^ line5 ^ (if admin then line6 else "") ^ line7;

daniel <eydaimon>
Fri 08 Aug 2008 01:27:15 PM UTC, comment #2: 

Agreed. And as you suggest, I would find that information more suitable in the body of the message, and the most common scenario is a single instance, so no need to put it in every subject.

daniel <eydaimon>
Fri 08 Aug 2008 11:42:18 AM UTC, comment #1: 

IMHO it makes sense to see the hostname MLDonkey is running on in the commit mail because people may run MLDonkey on several machines. Without that information its difficult (by reading mail headers) to judge on which machine the finished file awaits further action.

If such information should be part of the subject or be part of the body is another question, for me both is ok.

Small note: You could have attached your patch to this task, now they are seperate tracker entries.

Copied patch from https://savannah.nongnu.org/patch/?6600#comment0

Index: src/daemon/common/commonInteractive.ml
===================================================================
RCS file: /sources/mldonkey/mldonkey/src/daemon/common/commonInteractive.ml,v
retrieving revision 1.105
diff -r1.105 commonInteractive.ml
346c346
< Printf.sprintf "[mldonkey@%s] file received - %s" (Unix.gethostname ()) (file_best_name file)
---

> Printf.sprintf "mldonkey - %s complete." (file_best_name file)


348c348
< Printf.sprintf "mldonkey@%s, file received" (Unix.gethostname ())
---

> Printf.sprintf "mldonkey - download complete."

spiralvoice <spiralvoice>
Project Administrator
Fri 08 Aug 2008 10:01:02 AM UTC, original submission:  

THIS ITEM WAS REASSIGNED TO PATCH #6629
Adding the sender mail (which isn't even a real email) to the subject is unnecessary and consumes much of the subject.

Current subject:

[mldonkey@whatever.hostname.you.run.mldonkey.on] file received - Somefilename_or_something.rar

How about shortening it to?:
mldonkey: Somefilename_or_something.rar completed.

daniel <eydaimon>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Posted a comment)
  • -email is unavailable- added by eydaimon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-09-01 spiralvoice Reassign Itemmldonkey, a multi-networks file-sharing client, task #8478 => mldonkey, a multi-networks file-sharing client, patch #6629
    2008-09-01 spiralvoice Attached File- => Added mail_subject.patch, #16415
        Summarymail subject is too long => Mail: Move hostname from subject to body

    Back to the top


    Powered by Savane 3.7