taskmldonkey, a multi-networks file-sharing client - Tasks: task #4310, Let MLDonkey create its data in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #4310: Let MLDonkey create its data in $HOME/.mldonkey be default

Submitted by:  spiralvoice <spiralvoice>
Submitted on:  Sat 25 Jun 2005 11:35:48 AM UTC  
 
Category:  Core Priority:  3 - Low
Status:  None Assigned to:  None
Open/Closed:  Closed Should Start On:  Sat 25 Jun 2005 12:00:00 AM UTC
Should be Finished on:  Sat 25 Jun 2005 12:00:00 AM UTC

( Jump to the original submission)

Thu 07 Jul 2005 10:14:48 PM UTC, comment #7: 

Works as a charm here on MaxOSX. Nice work.

White_FrosT
Wed 06 Jul 2005 10:28:43 PM UTC, comment #6: 

Updated the patch, please test it
- incorporated MacOSX into the new mechanism, thanks to White_FrosT
- some internal code cleaning, replaced config_dir with home_dir
- created some backward compatability
  if the core is started in a directory where downloads.ini exists
  the core will use this directory instead of $HOME/.mldonkey

spiralvoice <spiralvoice>
Project Administrator
Mon 04 Jul 2005 11:02:56 PM UTC, comment #5: 

Uhm sorry, forgot to mention: yes, the $HOME variable works (exists) on mac osx too.

Anonymous
Mon 04 Jul 2005 11:01:03 PM UTC, comment #4: 

I did some testing, macosx is not recognised. So I guess it has just got to be:
[code]
  | "linux" | "freebsd" | "openbsd" | "solaris"| "darwin" ->
       Filename.concat (try Sys.getenv "HOME" with _ -> ".") config_dir_basename
[/code]
without the extra line for darwin.

Tested and works as intentioned.

Anonymous
Thu 30 Jun 2005 12:06:00 PM UTC, comment #3: 

Yeah, that would be nice. I think you can change the patch for
yourself;-) I would prefer using $HOME if it is possible.

BTW: I think Autoconf.system should be changed from "Darwin" to
"MacOSX" or something similar so it is clearer.

spiralvoice <spiralvoice>
Project Administrator
Thu 30 Jun 2005 10:29:01 AM UTC, comment #2: 

According to http://www.biostat.wisc.edu/bcg/sup/macsup/unixtips.html and http://faculty.rmwc.edu/itc/tutorials/OSX.html the location of the homedir of the users is just /Users/[username]/

But in #macdev they said it should be the same at in any other unix, so you could add darwin in that list. If you like I can test it for you, I have a small OS/X server here.

White_FrosT
Tue 28 Jun 2005 07:28:00 PM UTC, comment #1: 

Please test this patch, I still don´t know how to get the homedir
on MacOSX, any help?

spiralvoice <spiralvoice>
Project Administrator
Sat 25 Jun 2005 11:35:48 AM UTC, original submission:  

This is a feature request which would be released in version 2.6.
As this is a major change in comparison to current behaviour
users need to have attention for this change so a new minor
release number would be adequate.

Coding this would be easy in commonOptions.ml

      (
        try
          let s = Sys.getenv "MLDONKEY_DIR" in
          if s = "" then "." else s
        with _ ->
            !!mldonkey_directory
      ), home_dir

"else s" should be changed to something like this:

else match Autoconf.system with
    "windows" -> Sys.getenv "USERPROFILE" ^ config_dir_basename (*to be tested*)
  | "unix" "freebsd" "openbsd" "solaris" -> Sys.getenv "HOME" ^ config_dir_basename
  | "darwin" -> () (*don´t know, any help?*)
  | _ -> "."

This code is only an example.
config_dir_basename means this:

let hidden_dir_prefix =
  if Autoconf.system = "windows" then "" else "."

let config_dir_basename = hidden_dir_prefix ^ "mldonkey"

This is necessary as directories on Windows can´t start with "."

Other clients like aMule and eDonkey already are working like
this so MLDonkey would be more compatible. The MLDonkey Debian
package also puts MLDonkey files and dirs into $HOME/.mldonkey

spiralvoice <spiralvoice>
Project Administrator

 

Attached Files
file #3678:  homedir2.patch added by spiralvoice (15KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

 

 

Follow 6 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-07-08 spiralvoice Reassign ItemFrom group mldonkey, a multi-networks file-sharing client, task tracker => To group mldonkey, a multi-networks file-sharing client, patch tracker
2005-07-06 spiralvoice Attached File#211 => Removed
2005-07-06 spiralvoice Attached File#205 => Removed
2005-07-06 spiralvoice Attached File- => Added homedir2.patch, #212
2005-07-05 White_FrosT Attached File- => Added homedir2.patch, #211
2005-06-28 spiralvoice Attached File- => Added homedir.patch, #205

Back to the top


Powered by Savane 3.7