bugftp.proxy - FTP Proxy Server - Bugs: bug #10008, waitpid handling still wrong in...

 
 

bug #10008: waitpid handling still wrong in daemon mode

Submitted by:  Simon Baatz <bnomis26>
Submitted on:  Sat 14 Aug 2004 03:25:08 PM UTC  
 
Severity: 3 - NormalPriority: 5 - Normal
Item Group: Crash ErrorStatus: Fixed
Privacy: PublicAssigned to: Andreas Schoenberg <asg>
Originator Name: Open/Closed: Closed
Release: 1.2.3Operating System: Linux
Fixed Release: 1.2.4Planned Release: 1.2.4

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 03 Feb 2005 10:08:32 AM UTC, comment #1:

Fixed.

Andreas Schoenberg <asg>
Project AdministratorIn charge of this item.
Sat 14 Aug 2004 03:25:08 PM UTC, original submission:

Although ftp-proxy does not ignore SIGCHLD signals in daemon mode anymore in version 1.2.3, the following code is still in ftp.c (line 1078):

/*

  • In standalone mode we do not receive the SIGCHLD because
  • we set it to SIG_IGN -- 030406asg

*/

if (x->config->standalone == 0 && waitpid(pid, &rc, 0) < 0) {
syslog(LOG_NOTICE, "-ERR: error while waiting for trp: %
s", strerror(errno));
exit (1);
}

rc = WIFEXITED(rc) != 0? WEXITSTATUS(rc): 1;

Thus, no waitpid call is performed at all in daemon (i.e. standalone) mode. The if clause should simply be

if (waitpid(pid, &rc, 0) < 0)
{

as it is the case with the other waitpid calls.

Patch is attached.

Simon Baatz <bnomis26>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #1651:  ftp.c.patch added by bnomis26 (486B - application/octet-stream - Patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 7 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Thu 03 Feb 2005 10:08:32 AM UTCasgStatusNone=>Fixed
  Assigned toNone=>asg
  Open/ClosedOpen=>Closed
  Releasecvs snapshot=>1.2.3
  Fixed Release=>1.2.4
  Planned Release=>1.2.4
Sat 14 Aug 2004 03:25:08 PM UTCbnomis26Attached File-=>Added ftp.c.patch, #1584

Back to the top


Powered by Savane 3.1-cleanup1