bugmldonkey, a multi-networks file-sharing client - Bugs: bug #10062, max_hard_download_rate has to be...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #10062: max_hard_download_rate has to be doubled

Submitted by:  spiralvoice <spiralvoice>
Submitted on:  Thu 19 Aug 2004 10:49:45 AM UTC  
 
Category: CoreSeverity: 3 - Normal
Item Group: Program malfunctionStatus: Ready For Test
Assigned to: spiralvoice <spiralvoice>Open/Closed: Closed
Release: Release: 2.6.3
Operating System: NoneBinaries Origin: CVS / Self compiled
CPU type: None

(Jump to the original submission Jump to the original submission)

Mon 29 Aug 2005 09:44:09 PM UTC, comment #9:

Changed bug status.

pango <mlpango>
Project Member
Mon 29 Aug 2005 12:47:51 AM UTC, comment #8:

Updated patch for Bittorrent upload.

pango <mlpango>
Project Member
Mon 29 Aug 2005 12:37:29 AM UTC, comment #7:

Bittorrent upload probably has exactly the same bug
(in BTClients.iter_upload, client_uploaded is incremented, then count_upload is called that also increments client_uploaded)...

pango <mlpango>
Project Member
Mon 29 Aug 2005 12:09:02 AM UTC, comment #6:

I think I've found the bug.

Code was added to donkey and bittorrent supports to increment client_downloaded fields using Swarmer transfer accounting.

Problem is, count_download already updates client_downloaded, so transfers end up being counted twice.

(Untested) patch attached.

pango <mlpango>
Project Member
Fri 10 Jun 2005 12:31:43 AM UTC, comment #5:

According to https://savannah.nongnu.org/patch/?func=detailitem&item_id=4046#comment1
it works now. As it is fixed I will close this bug.
In the code I left a "TODO" note for later work, no need to have
an open bug report for it now.

spiralvoice <spiralvoice>
Project AdministratorIn charge of this item.
Thu 26 May 2005 10:28:06 AM UTC, comment #4:

see patch #4046

spiralvoice <spiralvoice>
Project AdministratorIn charge of this item.
Wed 04 May 2005 07:01:09 AM UTC, comment #3:

a small comment from the 2.5.30-15 version, seen on the donkey network:
when a source is uploading us data for a file, the downloaded part from the source is the double of the downloaded part of the file.
You can observe that from the GTK2 GUI:
- add a new file
- expand the file in the GUI to see the sources
- wait for the first source to upload to us
- watch carefully the 'Downloaded' column. The file downloaded size is exactly half of the data downloaded from the source.

su_blanc <su_blanc>
Project Member
Wed 13 Apr 2005 09:10:36 AM UTC, comment #2:

that patch doesnt actually fix the bug it just hides it

Anonymous
Tue 12 Apr 2005 11:12:03 AM UTC, comment #1:

Please try the attached patch.

spiralvoice <spiralvoice>
Project AdministratorIn charge of this item.
Thu 19 Aug 2004 10:49:45 AM UTC, original submission:

This bug is still there:
"2004/05/05: Fabrice (version 2.5.21 = 2.6pre3, tag release-2-5-21)
- For some reason, download seems to be limited to max_hard_download_rate/2.
Try to increase this option until a fix is found. "
http://mldonkey.berlios.de/modules.php?name=Forums&file=viewtopic&p=14447#14447

spiralvoice <spiralvoice>
Project AdministratorIn charge of this item.

 

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 14 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Mon 29 Aug 2005 09:56:50 PM UTCmlpangoReassign ItemFrom group mldonkey, a multi-networks file-sharing client, bugs tracker=>To group mldonkey, a multi-networks file-sharing client, patch tracker
Mon 29 Aug 2005 09:56:01 PM UTCmlpangoAttached File#2401=>Removed
Mon 29 Aug 2005 09:55:49 PM UTCmlpangoAttached File#2874=>Removed
Mon 29 Aug 2005 09:44:09 PM UTCmlpangoStatusFixed=>Ready For Test
  Assigned toNone=>spiralvoice
  Open/ClosedClosed=>Open
  Release2.5.30.15=>2.6.3
Mon 29 Aug 2005 12:47:51 AM UTCmlpangoAttached File-=>Added fix_doubled_download_rates.patch, #2875
Mon 29 Aug 2005 12:09:02 AM UTCmlpangoAttached File-=>Added fix_doubled_download_rates.patch, #2874
Fri 10 Jun 2005 12:31:43 AM UTCspiralvoiceStatusReady For Test=>Fixed
  Open/ClosedOpen=>Closed
Thu 26 May 2005 10:28:06 AM UTCspiralvoiceStatusNone=>Ready For Test
  Release2-5-27=>2.5.30.15
Tue 12 Apr 2005 11:12:04 AM UTCspiralvoiceAttached File-=>Added max_hard_download_rate.patch, #2401

Back to the top


Powered by Savane 3.1-cleanup1