bugmonotone - Bugs: bug #11062, calculate_composite_change_set...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #11062: calculate_composite_change_set should clear returned change_set

Submitted by:  Nathaniel Smith <njs>
Submitted on:  Sat 20 Nov 2004 12:04:35 PM UTC  
 
Category: NoneSeverity: 1 - Wish
Item Group: incorrect behaviorStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed
mtn version --full: 

Sat 26 Nov 2005 12:54:15 AM UTC, comment #1:

Since this bug was added, the code has acquired an I(composite.empty()) so the case you describe cannot occur. Furthermore the code will soon be replaced with roster/cset operations, so this bug is dead.

graydon hoare <graydon>
Project Member
Sat 20 Nov 2004 12:04:35 PM UTC, original submission:

calculate_composite_change_set just calls into calculate_change_sets_recursive. calculate_change_sets_recursive checks to see if the ancestor and child are the same, and if so returns without doing so. If someone calls calculate_composite_change_set with child and ancestor the same, then it will be a no-op, and leave whatever junk was in the passed-in change_set to be returned.

Nathaniel Smith <njs>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 26 Nov 2005 12:54:15 AM UTCgraydonStatusNone=>Fixed
  Open/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1