bugmonotone - Bugs: bug #11114, 'add' and 'drop' are obscenely...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #11114: 'add' and 'drop' are obscenely slow with explicitly listed files

Submitted by:  Nathaniel Smith <njs>
Submitted on:  Tue 23 Nov 2004 11:43:50 AM UTC  
 
Category: working copySeverity: 3 - Normal
Item Group: incorrect behaviorStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed
mtn version --full: 

Sat 26 Nov 2005 12:57:36 AM UTC, comment #2:

Fixed since long ago.

graydon hoare <graydon>
Project Member
Thu 25 Nov 2004 03:05:49 PM UTC, comment #1:

From briefly running Shark (an OS X profiling tool) over monotone drop, it seems that the majority of time is spent in the boost filesystem library's m_path_append() (doing string appends etc), called via sanity_check_path_item() in change_set.cc

I'm not really sure of the solution.... Batch processing works for "add" and "drop" (I haven't looked how ugly it would get), though for "rename" it only takes two arguments.

Matt Johnston <mkj>
Project Member
Tue 23 Nov 2004 11:43:50 AM UTC, original submission:

Adding ~300 files with 'monotone add `find -type f`' takes minutes and minutes. Almost all of the time seems to be spent in bookkeeping that build_addition does (calling normalize_change_set, concatenate_change_sets, etc.); currently we redo all that bookkeeping for every argument. Not sure which part of the bookkeeping is eating up all the time, but the same command becomes almost instantaneous if I hack build_addition to take a set of files to add and handle them all in a batch. 'drop' has the same problem, though I have not checked to see if the same answer works.

Haven't committed this because I'm not sure it's quite appropriate; perhaps the right answer is to make those bookkeeping functions faster, thus speeding up many other parts of monotone and avoiding uglifying the work.hh interface? Or is that not plausible?

Nathaniel Smith <njs>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 26 Nov 2005 12:57:36 AM UTCgraydonStatusNone=>Fixed
  Open/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1