bugThe nmh Mail Handling System - Bugs: bug #11139, mhl -form mhl.reply omits '> '...

 
 

bug #11139: mhl -form mhl.reply omits '> ' on some lines

Submitted by:  None
Submitted on:  Fri 26 Nov 2004 02:39:27 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: NoneOpen/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 10 Apr 2007 06:18:51 AM UTC, comment #4:

Should be fixed in CVS now. It was indeed a BUFSIZ problem. putcomp() in mhlsbr.c was assuming that only the first call on the body had the buffer beginning at the start of a line.

Joel Reicher <jjr>
Project Member
Sun 20 Nov 2005 04:16:23 PM UTC, comment #3:

I can't reproduce this bug on Linux with either 1.1RC4 or 1.0.4... I think the buffer in question is probably BUFSIZ bytes long, which is 1024 on FreeBSD but 8192 on Linux, but even modifying the sample file to have a newline after 8191 chars didn't seem to provoke the bug.

There has been a change to the handling of newlines at end of buffers between 1.0.4 and 1.1RC4 -- if you felt like trying out 1.1RC4 to see if the bug has gone that would be helpful :-)

Peter Maydell <pm215>
Project Administrator
Fri 26 Nov 2004 02:56:33 PM UTC, comment #2:

Got myself a savannah account so I could track this bug. It's by me, Nick Barnes <Nick.Barnes@pobox.com>

Nick Barnes <nickbarnes>
Fri 26 Nov 2004 02:41:22 PM UTC, comment #1:

I have attached a sample message file which demonstrates the problem. Here you can see it in action:

$ /usr/local/libexec/nmh/mhl -form mhl.reply < 1 | tail

> 123 including the newlines at the end of each line. 890 8
> 123 16 lines of 64 characters (63 plus newline), less 890 9
> 123 one character at the end of the last line. 890 10
> 123 Obviously mhl has a fixed size buffer somewhere, 890 11
> 123 char[1024], and there's a bug in handling a 890 12
> 123 newline when it occurs as the last character in 890 13
> 123 the buffer. Or something. In any case, the result 890 14
> 123 is that 890 15
> 123 89016

this line has no > at the head. 890 1

Anonymous
Fri 26 Nov 2004 02:39:27 PM UTC, original submission:

mhl -form mhl.reply should put '> ' before every body line, but in fact sometimes it misses some body lines, when a multiple of 1023 characters precedes the line in the body.

This is nmh 1.0.4 on FreeBSD.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #2106:  1 added by None (4KiB - application/octet-stream - A test message which demonstrates the problem.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jjr (Posted a comment)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 10 Apr 2007 06:18:51 AM UTCjjrStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Fri 26 Nov 2004 02:39:27 PM UTCNoneAttached File-=>Added 1, #1917

    Back to the top


    Powered by Savane 3.1-cleanup1