bugrdiff-backup - Bugs: bug #11398, possible solution for nfs/remote...

 
 

bug #11398: possible solution for nfs/remote filesystem problem

Submitted by:  None
Submitted on:  Sun 26 Dec 2004 01:50:14 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Benedict Escoto <bescoto>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 26 Mar 2005 05:53:47 PM UTC, comment #1:

Hi thank you for finding this difficult bug, and sorry for the delay. I think your patch is good, but I've made a small modification, which I think only closes the file in the cases it was left open before.

I'm attaching the modified patch and closing this bug. Perhaps you could try it out and reopen if the new patch doesn't solve your problem also.

In the next day or two I will release new versions that have this patch included, so you could wait until then and tell me if it still works for you.

Benedict Escoto <bescoto>
Project AdministratorIn charge of this item.
Sun 26 Dec 2004 01:50:14 PM UTC, original submission:

I'm currently using rdiff-backup 0.13.4 (on OS X). As long as I know of rdiff-backup, I was unable to do backups to nfs volumes as the target. Currently processing power on my "file server" is the bottleneck so running rdiff-backup remotely is no solution for me.

rdiff-backup crashes trying to delete a directory in the target directory if the directory being deleted contains at least one file.

This seems to be due to the fact that at this time some file handles are still open. (This is a problem of rdiff-backup, not of nfs or some other network file system)
While on a local filesystem it is possible to delete a directory with a locked file inside, nfs renames locked but deleted files so something like .nfs?????. Thus it is impossible to delete the directory.

As far as I was able to debug, before deleting a file, it is opened while creating an rdiff signature (somewhere in librsync.py, in SigFile, as far as I remember). This file handle seems to be never released causing the error described above.

My complete knowledge of python comes from reading rdiff-backup source code, so I am not completely sure when it comes to the patch I supply here.
All I can say is, that for me backing up over nfs now works fine.

Feel free to contact me.
Regards,
Maximilian Mehnert

maximilian.mehnert at charite.de

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #2795:  backup.py.diff2 added by bescoto (712B - application/octet-stream)
file #2264:  backup.py.diff added by None (344B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 6 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 26 Mar 2005 05:55:59 PM UTCbescotoStatusNone=>Fixed
Sat 26 Mar 2005 05:54:42 PM UTCbescotoOpen/ClosedOpen=>Closed
Sat 26 Mar 2005 05:53:47 PM UTCbescotoAssigned toNone=>bescoto
  Attached File-=>Added backup.py.diff2, #2355
Sat 26 Mar 2005 05:49:23 PM UTCbescotoCarbon-Copy-=>Added -unavailable-
Sun 26 Dec 2004 01:50:14 PM UTCNoneAttached File-=>Added backup.py.diff, #1997

Back to the top


Powered by Savane 3.1-cleanup1