bugmonotone - Bugs: bug #12069, netsync broken at -Os

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #12069: netsync broken at -Os

Submitted by:  Nathaniel Smith <njs>
Submitted on:  Mon 21 Feb 2005 08:27:19 AM UTC  
 
Category: networkingSeverity: 1 - Wish
Item Group: crashStatus: Wont Fix
Privacy: PublicAssigned to: None
Open/Closed: Closed
mtn version --full: 

Mon 16 Jan 2006 01:46:34 AM UTC, comment #2:

This is an ancient compiler and I don't think it's reproducible, so never mind.

Nathaniel Smith <njs>
Project Member
Mon 21 Feb 2005 09:50:35 PM UTC, comment #1:

Testing on another database fails to confirm the dramatic speedup from -Os, making it much less desireable. So I'm downgrading this bug in importance.

Nathaniel Smith <njs>
Project Member
Mon 21 Feb 2005 08:27:19 AM UTC, original submission:

Compiling e7a25602021e4643995badb2ab4f6e25eb8fc8f9 with gcc 3.3.5 (Debian 1:3.3.5-8) using CFLAGS/CXXFLAGS="-Os -g -fno-strict-aliasing", netsync is broken. For instance, test 28 does not pass.

It fails, complaining that the protocol version number is <some random number> rather than "3". The random number changes each time if one runs the netsync repeatedly.

Initial investigation reveals that incoming packet correctly has its first byte as 0x03 when going over the network; the problem is somehow in parsing it. (Or perhaps it is parsing the previous packet wrongly, and thus losing sync.)

The problem is also not in read_netcmd(), which is correctly removing the first byte from the string it is passed; the problem is that this string is already corrupt.

It would be very nice to make this work, since an -Os monotone is roughly 15% smaller, and ~33% faster on changeset intensive operations like "rebuild".

Nathaniel Smith <njs>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Mon 16 Jan 2006 01:46:34 AM UTCnjsStatusNone=>Wont Fix
  Open/ClosedOpen=>Closed
Mon 21 Feb 2005 09:50:35 PM UTCnjsSeverity4 - Important=>1 - Wish

Back to the top


Powered by Savane 3.1-cleanup1