bugmonotone - Bugs: bug #12164, commit with locked db can corrupt...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #12164: commit with locked db can corrupt MT/revision

Submitted by:  Nathaniel Smith <njs>
Submitted on:  Sun 27 Feb 2005 11:30:38 AM UTC  
 
Category: NoneSeverity: 1 - Wish
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Closed
mtn version --full: 

monotone 0.16 (base revision: 36f208b096bf7b7734581108af2f142cd184ff8f)
Running on: Linux 2.4.27-2-686 #1 Thu Jan 20 11:10:41 JST 2005 i686
Changes since base revision:

new_manifest [f2052172d60c9e0b3c83e857e608eb8da1568fdf]

old_revision [36f208b096bf7b7734581108af2f142cd184ff8f]
old_manifest [f2052172d60c9e0b3c83e857e608eb8da1568fdf]

Sat 26 Nov 2005 02:49:49 AM UTC, comment #1:

Fixed in 0.20

Matt Johnston <mkj>
Project Member
Sun 27 Feb 2005 11:30:38 AM UTC, original submission:

I had a 'monotone diff' running in the background when I tried to commit. It let me fill out my changelog message, etc., then it bombed out saying "database locked". I smacked my forehad, killed the 'monotone diff', and went to commit again. This time, though, it errored out, saying that my base revision didn't exist.

Apparently before 'commit' bombed out, it wrote the new revision id to MT/revision. This revision didn't exist in the database (because the commit bombed out), and so I was stuck. I had to peer at monotone-viz for a while to figure out which revision I had been based against and echo that to MT/revision before I could actually commit my work.

My first thought was to move the logic that modifies MT/revision to occur after the database modifications, but then when I looked in commands.cc, it already works like that. So I'm not sure how this could have happened, but we should figure it out...

(Perhaps we should atomically update MT/ during commit, and check for rollback later? It's only MT/revision and MT/work that get touched...)

Nathaniel Smith <njs>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follows 1 latest change.

Date Changed By Updated Field Previous Value => Replaced By
Sat 26 Nov 2005 02:49:49 AM UTCmkjOpen/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1