bugrdiff-backup - Bugs: bug #12726, regression corruption with devices...

 
 

bug #12726: regression corruption with devices and non-root user

Submitted by:  dean gaudet <dgaudet>
Submitted on:  Mon 18 Apr 2005 11:05:03 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: dean gaudet <dgaudet>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 07 Aug 2005 06:46:13 PM UTC, comment #3:

Thanks, looks good. Not sure why I was using external mknod anyway. As for the windows users, maybe rdiff-backup will realize that windows doesn't have mknod and not try to make them. And if it crashes everything I'm sure they will complain and we can fix it then.

Benedict Escoto <bescoto>
Project Administrator
Sun 19 Jun 2005 08:39:29 PM UTC, comment #2:

fix committed to cvs

dean gaudet <dgaudet>
Project AdministratorIn charge of this item.
Tue 19 Apr 2005 01:02:35 AM UTC, comment #1:

i'm considering this patch... which does a self.touch() when the mknod fails.

i didn't like spawning the external mknod because it spews stuff to stderr when running non-root... instead i'm hoping it's ok to use os.mknod -- if i understand things it should compile fine even on windows but will raise an exception if it's actually invoked?

-dean

dean gaudet <dgaudet>
Project AdministratorIn charge of this item.
Mon 18 Apr 2005 11:05:03 PM UTC, original submission:

when rdiff-backup is running as a non-root user it cannot mknod devices. there is a situation where rdiff-backup can corrupt its state if it has to regress a deletion of a device.

i've attached a log setting up the problem and showing the traceback.

-dean

dean gaudet <dgaudet>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #2864:  fix1.patch added by dgaudet (1KiB - application/octet-stream - proposed fix)
file #2863:  rb.txt added by dgaudet (7KiB - text/plain - example log showing the bug and traceback)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 5 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 10 Aug 2005 05:49:57 AM UTCbescotoStatusNone=>Fixed
Sun 19 Jun 2005 08:39:29 PM UTCdgaudetOpen/ClosedOpen=>Closed
Fri 22 Apr 2005 04:36:48 PM UTCdgaudetAssigned toNone=>dgaudet
Tue 19 Apr 2005 01:02:36 AM UTCdgaudetAttached File-=>Added fix1.patch, #2414
Mon 18 Apr 2005 11:05:03 PM UTCdgaudetAttached File-=>Added rb.txt, #2413

Back to the top


Powered by Savane 3.1-cleanup1