bugrdiff-backup - Bugs: bug #12949, Invalid argument error on Mac OS X...

 
 

bug #12949: Invalid argument error on Mac OS X 10.4 (Tiger)

Submitted by:  Trevor Harmon <vocaro>
Submitted on:  Tue 03 May 2005 06:55:54 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 28 Jun 2005 07:27:57 PM UTC, comment #3:

thanks... the patch has been committed to cvs.

dean gaudet <dgaudet>
Project Administrator
Tue 31 May 2005 06:55:44 PM UTC, comment #2:

I've attached patch #2555, to fs_abilities.py (from version 0.13.6 of rdiff-backup), which modifies the error handling of the supports_unusual_chars function slightly. I'm new to Python, so this may not be the correct place to do the error handling, but it fixes the "OSError: [Errno 22] Invalid argument" on Mac OS X 10.4.

Daniel Westermann-Clark <danieltwc>
Mon 16 May 2005 09:32:47 PM UTC, comment #1:

I am getting this error and I am running OS X 10.3.9, with Fink:

Traceback (most recent call last):
File "/sw/bin/rdiff-backup", line 23, in ?
rdiff_backup.Main.Main(sys.argv[1:])
File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 280, in Main
take_action(rps)
File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 250, in take_action
elif action == "backup": Backup(rps[0], rps[1])
File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 303, in Backup
backup.Mirror(rpin, rpout)
File "/sw/lib/python2.4/site-packages/rdiff_backup/backup.py", line 38, in Mirror
DestS.patch(dest_rpath, source_diffiter)
File "/sw/lib/python2.4/site-packages/rdiff_backup/backup.py", line 218, in patch
ITR(diff.index, diff)
File "/sw/lib/python2.4/site-packages/rdiff_backup/rorpiter.py", line 282, in _call_
branch.start_process(*args)
File "/sw/lib/python2.4/site-packages/rdiff_backup/backup.py", line 534, in start_process
if diff_rorp.isdir(): self.prepare_dir(diff_rorp, base_rp)
File "/sw/lib/python2.4/site-packages/rdiff_backup/backup.py", line 560, in prepare_dir
base_rp.mkdir()
File "/sw/lib/python2.4/site-packages/rdiff_backup/rpath.py", line 775, in mkdir
self.conn.os.mkdir(self.path)

Anonymous
Tue 03 May 2005 06:55:54 AM UTC, original submission:

After installing python-2.4, librsync-0.9.6, and rdiff-backup-0.13.6 on Tiger, the following error occurs on any backup or restore:

Traceback (most recent call last):
File "/sw/bin/rdiff-backup", line 23, in ?
rdiff_backup.Main.Main(sys.argv[1:])
File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 280, in Main
take_action(rps)
File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 250, in take_action
elif action == "backup": Backup(rps[0], rps[1])
File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 291, in Backup
backup_set_fs_globals(rpin, rpout)
File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 411, in backup_set_fs_globals
dest_fsa = rpout.conn.fs_abilities.get_fsabilities_readwrite(
File "/sw/lib/python2.4/site-packages/rdiff_backup/fs_abilities.py", line 394, in get_fsabilities_readwrite
return FSAbilities(desc_string).init_readwrite(
File "/sw/lib/python2.4/site-packages/rdiff_backup/fs_abilities.py", line 152, in init_readwrite
if override_chars_to_quote is None: self.set_chars_to_quote(subdir)
File "/sw/lib/python2.4/site-packages/rdiff_backup/fs_abilities.py", line 267, in set_chars_to_quote
if supports_unusual_chars(): self.chars_to_quote = "A-Z;"
File "/sw/lib/python2.4/site-packages/rdiff_backup/fs_abilities.py", line 245, in supports_unusual_chars
rp = subdir.append(filename)
File "/sw/lib/python2.4/site-packages/rdiff_backup/rpath.py", line 907, in append
return self.__class__(self.conn, self.base, self.index + (ext,))
File "/sw/lib/python2.4/site-packages/rdiff_backup/rpath.py", line 666, in _init_
else: self.setdata()
File "/sw/lib/python2.4/site-packages/rdiff_backup/rpath.py", line 691, in setdata
self.data = self.conn.C.make_file_dict(self.path)
OSError: [Errno 22] Invalid argument: 'NSF-backup/rdiff-backup-data/rdiff-backup.tmp.2/\xaf'

It seems that make_file_dict does not like chr(175), as specified in supports_unusual_chars. Changing this function to return 0 fixes the problem and allows rdiff-backup to work without any apparent problems on Tiger.

Trevor Harmon <vocaro>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #3023:  fs_abilities-tiger.patch added by danieltwc (624B - text/x-patch - Patch to fix OSError on Mac OS X 10.4)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue 28 Jun 2005 07:27:57 PM UTCdgaudetStatusNone=>Fixed
  Open/ClosedOpen=>Closed
Tue 31 May 2005 06:48:50 PM UTCdanieltwcAttached File-=>Added fs_abilities-tiger.patch, #2555
  Carbon-Copy-=>Added danieltwc

Back to the top


Powered by Savane 3.1-cleanup1