bugmonotone - Bugs: bug #13051, Incorrect handling of EDITOR...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #13051: Incorrect handling of EDITOR variable

Submitted by:  None
Submitted on:  Tue 10 May 2005 06:12:55 PM UTC  
 
Category: error handlingSeverity: 3 - Normal
Item Group: incorrect behaviorStatus: Invalid
Privacy: PublicAssigned to: None
Open/Closed: Closed
mtn version --full: 

monotone 0.19 (base revision: 168adf9537ff136c9b7fe7faad5991f92859390d)
Running on: Linux 2.6.11-1.14_FC3 #1 Thu Apr 7 19:23:49 EDT 2005 i686
Changes since base revision:

new_manifest [52a617d908ac6c4bb5b837ce5306f75155dc59ef]

old_revision [168adf9537ff136c9b7fe7faad5991f92859390d]
old_manifest [a9ee1d741b855fdcc0d038d64d913cef70da72f5]

patch "po/monotone.pot"
from [10e6d7cbad87eaa0dbe35c803cafa371567f024b]
to [0465f6ac8d09fac5938ac067747b179aca677b67]

Generated from data cached in the distribution;
further changes may have been made.

Generated from data cached in the distribution;
further changes may have been made.

Generated from data cached in the distribution;
further changes may have been made.

Sat 26 Nov 2005 02:41:17 AM UTC, comment #1:

Closing this as invalid, as I'm not convinced monotone's behaviour is incorrect here. Testing a mixture of other $EDITOR-using tools reveals that many others behave similarly to monotone.

In the face of this behaviour, you can supply arguments to your editor of choice by writing a small shell script, e.g.:

#! /bin/sh
nano -t "$@"

Since this bug was opened, the error handling has been somewhat improved to suggest where the problem lies, e.g.:

monotone: beginning commit on branch 'com.example.blah'
Error running editor 'nano -t' to enter log message
monotone: misuse: edit of log message failed

Matthew Gregan <kinetik>
Project Member
Tue 10 May 2005 06:12:55 PM UTC, original submission:

For the longest time, I have used Pico/Nano for my editor of choice. When calling from other programs, I prefer to use the -t option so Pico/Nano doesn't pester me to name the file, it just commits the changes to the filename passed to it on the command line.

Monotone does not handle the $EDITOR variable "nano -t". If my $EDITOR var is set to that, Monotone responds thusly:

# monotone commit
monotone: beginning commit on branch 'blah.blah.blah.project'
monotone: misuse: edit of log message failed
monotone: misuse: edit of log message failed

If I change it to just "nano", it works, but then I have to confirm the name of the file that was passed to nano. Every single time.

Monotone or LUA seem to be trying to confirm that the file exists before executing it, and since "nano -t" is not a valid filename, it fails all of my commits.

I have tried to fix this myself, but I am not familiar enough with LUA to correct the behavior.

Anonymous

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 26 Nov 2005 02:41:17 AM UTCkinetikStatusNone=>Invalid
  Open/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1