Thu 12 May 2005 03:48:28 PM UTC, original submission:
[I apparently cannot add to bug 13032 since I have no account]
The patch checked it indeed changes the behavior, but the result is still not correct. I get
2004-01-05 Ulrich Drepper <drepper@redhat.com>
* Makefile.am: Support separate libelf built.
* elfutils.spec.in: Create separata elfutils-libelf-devel package.
Install libdw DSOs.
* configure.ac (AC_CONFIG_SRCDIR): Use libelf/libelf.h as the file
name.
[...]
while the result should be
2005-02-22 Ulrich Drepper <drepper@redhat.com>
* Makefile.am (all_SUBDIRS): Don't add doc subdir for now.
* configure.ac: Don't use doc subdir for now.
2005-02-15 Ulrich Drepper <drepper@redhat.com>
* configure.ac: Remove AM_GNU_GETTEXT use. Use only AM_PO_SUBDIRS.
[...]
This did not surprise me since, as I wrote to Nathaniel in a private mail, there seems to be a fatal flaw in the implementation. I haven't looked at the actual code but the fact that the content or appearence of one file can effect the content of another file shows that.
The selection of a version associated with a branch point in one file is completely independent of the selection of a branch point in another file. One file might not be modified from day 1 (and might have dozens of branch names associated with it) while others change frequently and have high version numbers. The only guarantee is that all names are on the same branch or the trunk.
For the import this means monotone has to determine the sequence in which the names are created (easy: sort by version number associated with the name) and then for each file on the branch/trunk which is smaller than the branch number, add the revisions. Not sure how/whether you group them to simulate simultaneous checkins as patchsets. And I assume 1.23 < 1.23.0.2.
In this process there is absolutely no dependence on the version number in another file. The glue is the name and the name to version mapping has to be done for each file separately.
I think this is all obvious and maybe you feel lectured about the obvious, but the characteristics of the bug make me believe that the current code does something different.
|