bugGCJ Java plugin - Bugs: bug #13153, gcjappletviewer does not quote...

 
 

bug #13153: gcjappletviewer does not quote arguments passed to exec()

Submitted by:  Timo Lindfors <lindi>
Submitted on:  Sun 22 May 2005 05:42:21 PM UTC  
 
Category: NoneSeverity: 5 - Average
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 27 Apr 2006 08:22:13 PM UTC, comment #1:

This works

Lillian Angel <langel>
Project Member
Sun 22 May 2005 05:42:21 PM UTC, original submission:

The debian bug report at

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=307196

shows how

gcjappletviewer 'http://www.openstreetmap.org/edit/applet.jsp?lat=37.565&lon=22.799&scale=10000.0'

passes the url to exec() without quoting it so that shell interpretes "&". I'm forwarding this bug report here as it would be nice to get fixed in upstream too. I suggest the following patch:

--- gcjappletviewer.orig 2005-05-15 20:47:33.000000000 +0000
+++ /usr/bin/gcjappletviewer 2005-05-15 20:47:21.000000000 +0000
@@ -51,7 +51,7 @@
$GCJ_PROPERTIES = "$GCJ_PROPERTIES $arg";
}
else {
- $VIEWER_ARGS .= " $arg";
+ $VIEWER_ARGS .= " \"$arg\"";
}
}
$COMMANDLINE = "GCJ_PROPERTIES=\"$GCJ_PROPERTIES\" $NATIVE_VIEWER $VIEWER_ARGS";
@@ -63,7 +63,7 @@
$RUNTIME_ARGS .= " $arg";
}
else {
- $VIEWER_ARGS .= " $arg";
+ $VIEWER_ARGS .= " \"$arg\"";
}
}
$COMMANDLINE = "$JAVA -cp $JARFILE $RUNTIME_ARGS $MAINCLASS $VIEWER_ARGS";

Timo Lindfors <lindi>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follows 1 latest change.

Date Changed By Updated Field Previous Value => Replaced By
Thu 27 Apr 2006 08:22:13 PM UTClangelOpen/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1