buglwIP - A Lightweight TCP/IP stack - Bugs: bug #13179, Incoming ICMP packet type does not...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #13179: Incoming ICMP packet type does not use macros

Submitted by:  None
Submitted on:  Wed 25 May 2005 05:02:11 AM UTC  
 
Category: IPv4Severity: 1 - Wish
Item Group: Faulty BehaviourStatus: Invalid
Privacy: PublicAssigned to: Kieran Mansley <kieranm>
Open/Closed: ClosedPlanned Release: None
lwIP version: None

(Jump to the original submission Jump to the original submission)

Wed 11 Apr 2007 07:55:17 AM UTC, comment #6:

OK, we have a majority! Closing as invalid.

Kieran Mansley <kieranm>
Project AdministratorIn charge of this item.
Wed 11 Apr 2007 12:54:59 AM UTC, comment #5:

I think the bug report is incorrect as well.

Jonathan Larmour <jifl>
Project Member
Mon 26 Mar 2007 12:34:15 PM UTC, comment #4:

As no one else has commented on this, I'll mark is as "Postponed"

Kieran Mansley <kieranm>
Project AdministratorIn charge of this item.
Wed 21 Mar 2007 12:59:06 PM UTC, comment #3:

Hmm, anyone else with an opinion of whether this is right or wrong?

Kieran Mansley <kieranm>
Project AdministratorIn charge of this item.
Mon 26 Feb 2007 07:39:30 PM UTC, comment #2:

I have looked at it and believe that this bug report is incorrect, because those two lines in question works with a byte pointer, so result does not depend on endiands.

Dmitry Potapov <dpotapov>
Mon 26 Feb 2007 01:11:54 PM UTC, comment #1:

I'll look into this. Anyone else seen this problem, or have a patch, to make my job easier?

Kieran Mansley <kieranm>
Project AdministratorIn charge of this item.
Wed 25 May 2005 05:02:11 AM UTC, original submission:

In ICMP.C of version 1.1.0, there is code in icmp_input() that looks like this:

...
type = ((u8_t )p->payload);
code = (((u8_t )p->payload)+1);
switch (type) {
...

This isn't going to work with both ENDIANS. I suggest the following instead:

iecho = p->payload;
type = ICMPH_TYPE(iecho);
code = ICMPH_CODE(iecho);

If the ENDIAN is wrong, then IP_ECHO packets (type 8, code 0) will look like IP_ER packets (type 0, code 8).

Greg Sadosuk
-unavailable-

Anonymous

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jifl (Posted a comment)
  • -unavailable- added by dpotapov (Posted a comment)
  • -unavailable- added by kieranm (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 11 Apr 2007 07:55:17 AM UTCkieranmStatusPostponed=>Invalid
      Open/ClosedOpen=>Closed
    Mon 26 Mar 2007 12:34:15 PM UTCkieranmSeverity3 - Normal=>1 - Wish
      StatusNone=>Postponed
    Mon 26 Feb 2007 01:11:54 PM UTCkieranmAssigned toNone=>kieranm

    Back to the top


    Powered by Savane 3.1-cleanup1