bugLGPL'd VGABios - Bugs: bug #13322, The new line code '\n' should only...

 
 

bug #13322: The new line code '\n' should only increment the line number!

Submitted by:  None
Submitted on:  Tue 07 Jun 2005 06:33:44 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 02 Jul 2005 06:45:38 PM UTC, comment #1:

Fixed in CVS now.

Volker Ruppert <vruppert>
Project Administrator
Tue 07 Jun 2005 06:33:44 PM UTC, original submission:

Currently in vgabios.c -> biosfn_write_teletype() it sais:
case '\n':
xcurs=0;
ycurs++;
break;
I found that to distort the output of my boot sector where I drew a vertical line by outputting <gfx character>,<newline>,<backspace>,<gfx character>,<newline>...
The two 'real' bioses I have here both just move the cursor down one row, so I think it is a bug in vgabios.h that is just not obvious because every commad prompt or even the C libraries combine <newline> with <carriage return> anyway.
So it is probably more correct to write:
case '\n':
ycurs++;
break;

Thanks for all your work. It is really helpfull to test boot sectors in a running OS rather than to copy them to some floppy disk first and reboot!

Marco Leise

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 02 Jul 2005 06:45:38 PM UTCvruppertStatusNone=>Fixed
  Open/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1