bugmldonkey, a multi-networks file-sharing client - Bugs: bug #13541, world-writable...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #13541: world-writable incoming/directories/*

Submitted by:  me <skaus>
Submitted on:  Sat 25 Jun 2005 03:11:17 PM UTC  
 
Category: CoreSeverity: 3 - Normal
Item Group: Feature requestStatus: Fixed
Assigned to: NoneOpen/Closed: Closed
Release: Release: 2.5.30.16
Operating System: LinuxBinaries Origin: CVS / Self compiled
CPU type: Intel x86

(Jump to the original submission Jump to the original submission)

Fri 08 Jul 2005 01:27:44 PM UTC, comment #9:

Many thanks, I hadn't luck to have any complete downloads, yet; in order to test it

me <skaus>
Mon 04 Jul 2005 08:41:22 PM UTC, comment #8:

See patch #4140

spiralvoice <spiralvoice>
Project Administrator
Sun 03 Jul 2005 12:48:06 PM UTC, comment #7:

Updated patch which should work now.
Tested with several multifile torrents.

spiralvoice <spiralvoice>
Project Administrator
Thu 30 Jun 2005 11:17:33 PM UTC, comment #6:

Note for myself:
Subdirectories of a multifile torrent are still created 777,
see unix32.ml, let multi_rename

Unix.chmod d 0o777

spiralvoice <spiralvoice>
Project Administrator
Wed 29 Jun 2005 09:28:20 PM UTC, comment #5:

Please try the attached patch with current CVS, local tests worked.
The octal convertion code was done by Pango.
There is now a new option "create_dir_mask", defaults to 755.

spiralvoice <spiralvoice>
Project Administrator
Tue 28 Jun 2005 06:13:24 PM UTC, comment #4:

Yes, that's OK for me.

me <skaus>
Sun 26 Jun 2005 10:31:22 AM UTC, comment #3:

Is a default of 755 for the to be coded option OK for you?

spiralvoice <spiralvoice>
Project Administrator
Sun 26 Jun 2005 09:54:08 AM UTC, comment #2:

OK, I see.
However, it would be better to have an option to control the permissions, samba uses two options, one for files and one for directories. In my opinion, world-writable files are evil, but world-writable directories are even more evil. :-) Well, in a single-user system it doesn't matter much, but I haven't one.

BTW: as regards to the mentioned post of the thread: I would use "force user" or "force group" for the samba share, in order to overcome this problem, in conjunction with a well-written "valid users" option. But again, it wouldn't matter in a single-user environment.

me <skaus>
Sat 25 Jun 2005 07:49:47 PM UTC, comment #1:

No, its not related to bug #11185 which only deals with users.ini

The reason why dirs in incoming/directories/* have rights 777 is
that I coded it that way;-) on user request:

http://mldonkey.berlios.de/modules.php?name=Forums&file=viewtopic&p=19241#19241
and following discussion.

Should I make an option about it?

spiralvoice <spiralvoice>
Project Administrator
Sat 25 Jun 2005 03:11:17 PM UTC, original submission:

Maybe it's related to Bug #11185; when the bittorrent client downloads a directory into incoming/directories the permission of the directories is 0777, but the ones of the files is 0644. There should be no write-permission for "others" by default, I'd say.

me <skaus>

 

Attached Files
file #3133:  chmod.patch added by spiralvoice (8KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 6 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Mon 04 Jul 2005 08:41:22 PM UTCspiralvoiceStatusNone=>Fixed
  Open/ClosedOpen=>Closed
Sun 03 Jul 2005 12:48:06 PM UTCspiralvoiceAttached File-=>Added chmod.patch, #2651
Sun 03 Jul 2005 12:47:12 PM UTCspiralvoiceAttached File#2641=>Removed
Wed 29 Jun 2005 09:28:20 PM UTCspiralvoiceAttached File-=>Added chmod.patch, #2641
Sun 26 Jun 2005 10:31:22 AM UTCspiralvoiceItem GroupProgram malfunction=>Feature request

Back to the top


Powered by Savane 3.1-cleanup1