bugmldonkey, a multi-networks file-sharing client - Bugs: bug #13748, OV: Sometimes 128 buckets

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #13748: OV: Sometimes 128 buckets

Submitted by:  None
Submitted on:  Tue 12 Jul 2005 08:47:46 AM UTC  
 
Category: Overnet-PluginSeverity: 3 - Normal
Item Group: Program malfunctionStatus: Fixed
Assigned to: NoneOpen/Closed: Closed
Release: Release: 2.5.30.17
Operating System: LinuxBinaries Origin: CVS / Self compiled
CPU type: Intel x86

Wed 20 Jul 2005 09:07:42 PM UTC, comment #4:

Fixed by patch #4188

spiralvoice <spiralvoice>
Project Administrator
Tue 12 Jul 2005 01:47:37 PM UTC, comment #3:

ok, i see, theres the file...

bogeyman <bogeyman>
Project Member
Tue 12 Jul 2005 01:45:29 PM UTC, comment #2:

Found a typo in new_peers, but does not fix the problem, because now there are 100 peers pushed to bucket 128 ;o)

But should be applied to cvs anyway:

Index: src/networks/donkey/donkeyOvernet.ml
===================================================================
RCS file: /cvsroot/mldonkey/mldonkey/src/networks/donkey/donkeyOvernet.ml,v
retrieving revision 1.33
diff -u -r1.33 donkeyOvernet.ml
--- src/networks/donkey/donkeyOvernet.ml 10 Jul 2005 23:19:16 -0000 1.33
+++ src/networks/donkey/donkeyOvernet.ml 12 Jul 2005 13:22:20 -0000
@@ -727,7 +727,7 @@

while !n_used_buckets < 128 &&
Fifo.length prebuckets.(!n_used_buckets)
- = max_peers_per_bucket do
+ = max_peers_per_prebucket do
let b = prebuckets.(!n_used_buckets) in
incr n_used_buckets;
for i = 1 to Fifo.length b do

bogeyman <bogeyman>
Project Member
Tue 12 Jul 2005 01:33:13 PM UTC, comment #1:

Found out 20 peers are pushed forward until they reached bucket 128... strange

bogeyman <bogeyman>
Project Member
Tue 12 Jul 2005 08:47:46 AM UTC, original submission:

Not relatet to my ov-patches:
Sometimes i got in ov and kad 20 peers in the 128th buckets:

Number of used buckets 128 with 269 peers
bucket[0] : 20 peers (prebucket 100)
bucket[1] : 20 peers (prebucket 100)
bucket[2] : 20 peers (prebucket 99)
bucket[3] : 16 peers (prebucket 99)
bucket[4] : 20 peers (prebucket 100)
bucket[5] : 20 peers (prebucket 98)
bucket[6] : 20 peers (prebucket 91)
bucket[7] : 14 peers (prebucket 90)
bucket[8] : 13 peers (prebucket 36)
bucket[9] : 20 peers (prebucket 22)
bucket[10] : 18 peers (prebucket 12)
bucket[11] : 13 peers (prebucket 21)
bucket[12] : 20 peers (prebucket 25)
bucket[13] : 12 peers (prebucket 15)
bucket[14] : 9 peers (prebucket 7)
bucket[15] : 6 peers (prebucket 9)
bucket[16] : 3 peers (prebucket 8)
bucket[17] : 4 peers (prebucket 1)
bucket[18] : 0 peers (prebucket 8)
bucket[19] : 1 peers (prebucket 0)
bucket[128] : 0 peers (prebucket 20)

Seems to disturb the searches ?!

Anonymous

 

Attached Files
file #3211:  overnet.typo.patch added by bogeyman (729B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 20 Jul 2005 09:07:42 PM UTCspiralvoiceStatusNone=>Fixed
  Open/ClosedOpen=>Closed
Tue 12 Jul 2005 01:47:37 PM UTCbogeymanAttached File-=>Added overnet.typo.patch, #2692

Back to the top


Powered by Savane 3.1-cleanup1