bugutil-vserver - Bugs: bug #14026, vdlimit performs vc_add_limit()...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #14026: vdlimit performs vc_add_limit() before validation

Submitted by:  Kevin Pendleton <kevinp>
Submitted on:  Wed 03 Aug 2005 11:09:59 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: CrashStatus: Fixed
Privacy: PublicAssigned to: Enrico Scholz <ensc>
Open/Closed: ClosedComponent Version: alpha
Release: 208

Sat 29 Oct 2005 03:09:52 PM UTC, comment #1:

thx; should be fixed in CVS and 0.30.209+
http://savannah.nongnu.org/cgi-bin/viewcvs/util-vserver/util-vserver/src/vdlimit.c.diff?r1=1.2&r2=1.3

Enrico Scholz <ensc>
Project AdministratorIn charge of this item.
Wed 03 Aug 2005 11:09:59 PM UTC, original submission:

When executing an invalid command such as:

/usr/sbin/vdlimit --xid 300 --set space_total=2000000 --set space_used=3020400 --set inodes_total=2000000 --set inodes_used=3 --set reserved=5 /vservers/test/

vdlimit reports the following error:

vdlimit: vc_set_dlimit(): Invalid argument

But vdlimit has already performed vc_add_limit() and sets the values at 0, causing disk space problems on the vserver.

The validation of the values needs to be performed before executing vc_add_limit(), so that invalid results can not be set.

Also, more detailed error messages may also help. In this example, the error might include the information that space_used can not be larger then the space_total.

(Note: The invalid results were obtained by dynamically assigning the space_used based off of current usages.)

Kevin Pendleton <kevinp>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 29 Oct 2005 03:09:52 PM UTCenscStatusNone=>Fixed
  Assigned toNone=>ensc
  Open/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1