bugemacs-wiki, planner, and related modules - Bugs: bug #14229, emacs-wiki-visit-link finds wrong...

 
 

bug #14229: emacs-wiki-visit-link finds wrong tag in some circumstances

Submitted by:  Sergey Vlasov <vsu>
Submitted on:  Fri 19 Aug 2005 06:05:05 PM UTC  
 
Category: emacs-wikiSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Michael W. Olson <mwolson>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 03 Sep 2005 06:11:30 PM UTC, comment #2:

I think I've fixed this. Please re-open if this isn't the case.

2005-09-03 18:06:08 GMT Michael Olson <mwolson@gnu.org> patch-134

Summary:
Fix note visiting problem.
Revision:
emacs-wiki--main--1.0--patch-134

* emacs-wiki.el (emacs-wiki-visit-link): Make sure that we match against
a complete, whitespace-delimited tag. Thanks to Sergey Vlasov for the
report and suggested fix.

modified files:
ChangeLog emacs-wiki.el

Michael W. Olson <mwolson>
Project AdministratorIn charge of this item.
Fri 19 Aug 2005 06:10:03 PM UTC, comment #1:

Sorry, forgot to mention that the problem happens in emacs-wiki--main--1.0--patch-127 running in GNU Emacs 21.3.1.

Sergey Vlasov <vsu>
Fri 19 Aug 2005 06:05:05 PM UTC, original submission:

When using planner in its default configuration (planner-reverse-chronological-notes set to t), after 10 or more notes are added to a page, it is impossible to follow a link to the first note (Page#1) - instead the point is set to the note #10 (or #11, if it exists before #10, etc etc...).

However, the underlying problem is not specific to planner - it happens with any emacs-wiki file. The emacs-wiki-visit-link function finds the first tag which name begins with the specified tag string, therefore if the file contains a longer tag which has the name of a shorter tag as a prefix, and that longer tag is located before the shorter one, the shorter tag cannot be found. E.g., if you make a page called TagBug containing:

#tag_long

#tag

then if you follow link to [[TagBug#tag]], point is set at #tag_long instead of at #tag.

I have made a patch to fix this wrong behavior of emacs-wiki-visit-link; it is attached. The patch makes emacs-wiki-visit-link first look for the requested tag name followed by whitespace or end-of-line; if such search fails, the old way of looking for just a prefix is tried for backward compatibility.

Sergey Vlasov <vsu>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #3380:  01_emacs-wiki-visit-link.patch added by vsu (2KiB - text/x-patch - Fix emacs-wiki-visit-link to find the requested tag exactly)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 03 Sep 2005 06:11:30 PM UTCmwolsonAssigned toNone=>mwolson
  Open/ClosedOpen=>Closed
Sat 03 Sep 2005 06:11:29 PM UTCmwolsonStatusNone=>Fixed
Fri 19 Aug 2005 06:05:05 PM UTCvsuAttached File-=>Added 01_emacs-wiki-visit-link.patch, #2841

Back to the top


Powered by Savane 3.1-cleanup1