bugemacs-wiki, planner, and related modules - Bugs: bug #14336, bug in...

 
 

bug #14336: bug in emacs-wiki-markup-list-or-paragraph

Submitted by:  None
Submitted on:  Tue 30 Aug 2005 09:36:02 AM UTC  
 
Category: emacs-wikiSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Michael W. Olson <mwolson>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 25 Sep 2005 01:46:44 AM UTC, comment #1:

This should now be fixed. Thanks for the report!

2005-09-25 01:44:19 GMT Michael Olson <mwolson@gnu.org> patch-139

Summary:
Fix #14336: bug in emacs-wiki-markup-list-or-paragraph.
Revision:
emacs-wiki--main--1.0--patch-139

* emacs-wiki-publish.el (emacs-wiki-markup-list-or-paragraph): Add
save-match-data so the match data doesn't get clobbered.

modified files:
ChangeLog emacs-wiki-publish.el

Michael W. Olson <mwolson>
Project AdministratorIn charge of this item.
Tue 30 Aug 2005 09:36:02 AM UTC, original submission:

(defun emacs-wiki-markup-list-or-paragraph ()
"Markup a list entry or quoted paragraph.
The reason this function is so funky, is to prevent text properties
like read-only from being inadvertently deleted."
(if (null (match-string 2))
(let ((ws (match-string 4)))
(when (save-excursion
+ (save-match-data
(forward-line)
(or (eolp)
(looking-at "\\S-"))))

function looking-at will affect the match-data
so the following refer to match-beginning maybe not make any sense.

(let (block-start block-end)
(delete-region (match-beginning 4) (match-end 4))

So, I believe save-match-data should be added.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sun 25 Sep 2005 01:46:44 AM UTCmwolsonStatusNone=>Fixed
  Assigned toNone=>mwolson
  Open/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1