bugmonotone - Bugs: bug #14819, "monotone status" should...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #14819: "monotone status" should not ignore file arguments

Submitted by:  None
Submitted on:  Wed 19 Oct 2005 03:07:46 AM UTC  
 
Category: command line UISeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed
mtn version --full: 

monotone 0.23 (base revision: e32d161b8d5cde9f0968998cc332f82f82c27006)
Running on: Linux 2.6.8-24.18-default #1 Fri Aug 19 11:56:28 UTC 2005 i686
Changes since base revision:
new_manifest [68895899b164e1f443f988efef93e8384f1b182a]

old_revision [e32d161b8d5cde9f0968998cc332f82f82c27006]
old_manifest [68895899b164e1f443f988efef93e8384f1b182a]

Tue 06 Dec 2005 02:25:46 PM UTC, comment #1:

The call chain for this implies it's going to be slightly hard to fix; don't really want to pass some magic variable the whole way through this.

#0 app_state::restriction_includes (this=0xbffff4b0, path=@0x415ef80) at app_state.cc:198
#1 0x0008d888 in build_restricted_manifest_map (paths=@0xbfffe9dc, m_old=@0xbfffec40, m_new=@0xbfffec58, app=@0xbffff4b0) at manifest.cc:166
#2 0x0014ec00 in calculate_restricted_revision (app=@0xbffff4b0, args=@0xbffff3f8, rev=@0xbfffec70, m_old=@0xbfffec40, m_new=@0xbfffec58, excluded=@0xbfffeb48) at restrictions.cc:219
#3 0x0014f718 in calculate_restricted_revision (app=@0xbffff4b0, args=@0xbffff3f8, rev=@0xbfffec70, m_old=@0xbfffec40, m_new=@0xbfffec58) at restrictions.cc:237
#4 0x0000d084 in commands::cmd_status::exec (this=0xbffff4b0, app=@0xbffff4b0, args=@0xbffff3f8) at commands.cc:1284
#5 0x0000ba40 in commands::process (app=@0xbffff4b0, cmd=@0xbfffef78, args=@0xbffff3f8) at commands.cc:247
#6 0x0015b4cc in cpp_main (argc=-1073745868, argv=0x0) at monotone.cc:569
#7 0x0015c648 in main_with_signal_handlers (argc=3, argv=0xbffff944) at main.cc:303
#8 0x0015c8f4 in main (argc=-1073744720, argv=0x415ef80) at main.cc:374

Grahame Bowland <grahame>
Project Member
Wed 19 Oct 2005 03:07:46 AM UTC, original submission:

The command "monotone status t.c" produces output about the status of t.c if t.c has been added to the database, or "monotone: misuse: unknown path 't.c'" if it hasn't, or "monotone: warning: missing t.c" if it has been added and deleted.

I think "monotone status t.o" should produce some similar output about t.o -- a misuse message, at least. Instead, it acts just like "monotone status", and prints the status of everything in the working copy. I think monotone is applying its "ignored file" processing too hard and too early: it is removing all of the ignored file names from the command line, and then acting like I hadn't typed any file names at all.

(I think I would like "monotone status" to be extended to handle all file names as normal.
"monotone status foo" would produce the usual status output if foo were in the working copy and the database, or "missing_file foo" if it were in the database but had been deleted, or "ignored_file foo" if the ignore_file hook returns true, or "unknown_file foo" if ignore_file returns false and foo has not been added.)

Anonymous

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue 25 Apr 2006 11:56:32 PM UTCtbrownawStatusNone=>Fixed
  Open/ClosedOpen=>Closed
Tue 06 Dec 2005 02:25:46 PM UTCgrahamemtn version --fullmonotone 0.23 (base revision: e32d161b8d5cde9f0968998cc332f82f82c27006) Running on: Linux 2.6.8-24.18-default #1 Fri Aug 19 11:56:28 UTC 2005 i686 Changes since base revision: new_manifest [68895899b164e1f443f988efef93e8384f1b182a] old_revision [e32d161b8d5cde9f0968998cc332f82f82c27006] old_manifest [68895899b164e1f443f988efef93e8384f1b182a]=>monotone 0.23 (base revision: e32d161b8d5cde9f0968998cc332f82f82c27006) Running on: Linux 2.6.8-24.18-default #1 Fri Aug 19 11:56:28 UTC 2005 i686 Changes since base revision: new_manifest [68895899b164e1f443f988efef93e8384f1b182a] old_revision [e32d161b8d5cde9f0968998cc332f82f82c27006] old_manifest [68895899b164e1f443f988efef93e8384f1b182a]

Back to the top


Powered by Savane 3.1-cleanup1