bugmldonkey, a multi-networks file-sharing client - Bugs: bug #14856, mlnet is linked to X and GTK libs...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #14856: mlnet is linked to X and GTK libs when using --enable-gui

Submitted by:  spiralvoice <spiralvoice>
Submitted on:  Tue 25 Oct 2005 12:32:58 PM UTC  
 
Category: CoreSeverity: 4 - Important
Item Group: Compilation problemStatus: None
Assigned to: NoneOpen/Closed: Closed
Release: Release: 2.6.6
Operating System: LinuxBinaries Origin: CVS / Self compiled
CPU type: Intel x86

Wed 26 Oct 2005 07:02:44 PM UTC, comment #4:

Thanks, this patch works now, will be applied to CVS.

spiralvoice <spiralvoice>
Project Administrator
Wed 26 Oct 2005 06:10:55 PM UTC, comment #3:

my fault... the GTK C flags shall be in CFLAGS otherwise we can't find headers.
The patch attached should work.

su_blanc <su_blanc>
Project Member
Wed 26 Oct 2005 11:13:38 AM UTC, comment #2:

Attached your patch, mlnet now links without X + GTK libs, thanks.
But now GTK2 GUI mlgui does not compile anymore:

/usr/local/bin/ocamlc.opt -verbose -ccopt "-I /byterun -o src/gtk2/gui/x11/eggtrayicon.o" -ccopt "-g -O2 -pthread" -ccopt " " -cclib "-lz " -cclib -lbz2 -cclib -lz -cclib -lgd -cclib -lfreetype -cclib -lm -ccopt -W -ccopt -Wall -ccopt -Wno-unused -cclib -ljpeg -cclib -lpng -ccopt -DHAVE_JPEG -ccopt "-pthread" -c src/gtk2/gui/x11/eggtrayicon.c
+ gcc -fno-defer-pop -Wall -D_FILE_OFFSET_BITS=64 -D_REENTRANT -fPIC -c -I /byterun -o src/gtk2/gui/x11/eggtrayicon.o -g -O2 -pthread -W -Wall -Wno-unused -DHAVE_JPEG -pthread -I'/usr/local/lib/ocaml' 'src/gtk2/gui/x11/eggtrayicon.c'
src/gtk2/gui/x11/eggtrayicon.c:24:28: gtk/gtkversion.h: No such file or directory

This is the compile line for that file without the patch:

/usr/local/bin/ocamlc.opt -verbose -ccopt "-I /byterun -o src/gtk2/gui/x11/eggtrayicon.o" -ccopt "-g -O2 -pthread" -ccopt " " -cclib "-lz " -ccopt "-I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include " -cclib "-lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm -lpangocairo-1.0 -lpango-1.0 -lcairo -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0 " -cclib -lbz2 -cclib -lz -cclib -lgd -cclib -lfreetype -cclib -lm -ccopt -W -ccopt -Wall -ccopt -Wno-unused -cclib -ljpeg -cclib -lpng -ccopt -DHAVE_JPEG -ccopt "-pthread" -c src/gtk2/gui/x11/eggtrayicon.c
+ gcc -fno-defer-pop -Wall -D_FILE_OFFSET_BITS=64 -D_REENTRANT -fPIC -c -I /byterun -o src/gtk2/gui/x11/eggtrayicon.o -g -O2 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -W -Wall -Wno-unused -DHAVE_JPEG -pthread -I'/usr/local/lib/ocaml' 'src/gtk2/gui/x11/eggtrayicon.c'

spiralvoice <spiralvoice>
Project Administrator
Tue 25 Oct 2005 01:56:03 PM UTC, comment #1:

I think it's due to the tray icon...
The following points should do the trick to suppress the links

remove in Makefile.in (#line 140)

LIBS_flags += -ccopt "$(GTKCFLAGS) $(GTKLLIBS)" -cclib "$(GTKLFLAGS)"

and rip the GTK flags for newgui2 in (about line 800)

ifneq ("$(GUI)" , "no")
ifeq ("$(GUI)", "newgui2")
SUBDIRS += $(SRC_GUI) $(SRC_GUI)/x11 $(SRC_GUI)/win32 $(ICONS_CHOICE) +lablgtk2
GTK_LIBS_byte=-ccopt "$(GTKCFLAGS) $(GTKLLIBS)" -cclib "$(GTKLFLAGS)" -I +lablgtk2 $(LABLGL_CMA) lablgtk.cma gtkInit.cmo lablrsvg.cma
GTK_LIBS_opt=-ccopt "$(GTKCFLAGS) $(GTKLLIBS)" -cclib "$(GTKLFLAGS)" -I +lablgtk2 $(LABLGL_CMXA) lablgtk.cmxa gtkInit.cmx lablrsvg.cmxa
GTK_STATIC_LIBS_opt=-ccopt "$(GTKCFLAGS) $(GTKLLIBS)" -cclib "$(GTKLFLAGS)" -I +lablgtk2 lablgtk.cmxa gtkInit.cmx lablrsvg.cmxa
else
SUBDIRS += $(SRC_GUI) $(CONFIGWIN) $(OKEY) $(GPATTERN) $(ICONS_CHOICE) +lablgtk $(SRC_PROGRESS)
GTK_LIBS_byte=-I +lablgtk $(LABLGL_CMA) lablgtk.cma
GTK_LIBS_opt=-I +lablgtk $(LABLGL_CMXA) lablgtk.cmxa
GTK_STATIC_LIBS_opt=-I +lablgtk lablgtk.cmxa
endif

su_blanc <su_blanc>
Project Member
Tue 25 Oct 2005 12:32:58 PM UTC, original submission:

topic says it all

spiralvoice <spiralvoice>
Project Administrator

 

Attached Files
file #2789:  gtkCFlag.patch added by su_blanc (2KiB - text/x-patch)
file #2788:  mlnet_no_xlibs.patch added by spiralvoice (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 26 Oct 2005 07:02:46 PM UTCspiralvoiceReassign ItemFrom group mldonkey, a multi-networks file-sharing client, bugs tracker=>To group mldonkey, a multi-networks file-sharing client, patch tracker
Wed 26 Oct 2005 06:10:55 PM UTCsu_blancAttached File-=>Added gtkCFlag.patch, #3065
Wed 26 Oct 2005 11:13:39 AM UTCspiralvoiceAttached File-=>Added mlnet_no_xlibs.patch, #3064

Back to the top


Powered by Savane 3.1-cleanup1