bugmonotone - Bugs: bug #15088, Missing...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #15088: Missing SHELL32.DLL:SHGetFolderPathA, Version 0.24 can't run on Windows 98

Submitted by:  Henry Nestler <henryn>
Submitted on:  Mon 28 Nov 2005 01:24:09 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: crashStatus: Fixed
Privacy: PublicAssigned to: Matthew Gregan <kinetik>
Open/Closed: Closed
mtn version --full: 

monotone 0.24
Running on: Windows 95/98/SE/ME (4.10, build 67766446)

(Jump to the original submission Jump to the original submission)

Wed 14 Dec 2005 07:41:57 AM UTC, comment #6:

This was fixed in 71239c6b3325d289e9760845519ea35b01713d8c and Henry has confirmed that the fix works as expected. Closing bug.

Matthew Gregan <kinetik>
Project MemberIn charge of this item.
Mon 28 Nov 2005 09:00:31 PM UTC, comment #5:

To be clear, we are trying to use SHGetFolderPathA in monotone. win32/fs.cc refers to SHGetFolderPath, but this is really just a macro that is #defined in the Windows includes as either SHGetFolderPathA or SHGetFolderPathW, depending on whether you're building for ANSI or Unicode.

I overlooked the 'Remarks' section of the MSDN documentation for this function earlier That section does indeed point towards SHFolder.dll. I suppose they mean that SHGetFolderPath is supported on Win95 if the user has IE5 installed and the software developer has shippped SHFolder.dll with their application.

So, it looks like SHFolder.dll is what you need on earlier versions of Windows, but the released monotone 0.24 binary hasn't been linked against SHFolder.lib, so it won't work out of the box. I'll make sure this is fixed in the next release.

I'm in the process of reviewing our other Win32 API uses, and I'll update the monotone documentation with a specific minimum OS/software requirement list for Windows once I'm complete.

(Also changing the bug to analyzed and 'will fix later', and assigning to me--it's clear now that I haven't handled the use of SHGetFolderPath correctly, so it's a valid bug.)

Matthew Gregan <kinetik>
Project MemberIn charge of this item.
Mon 28 Nov 2005 08:33:49 PM UTC, comment #4:

Perhaps SHGetFolderPath would work, but I not known.

After reading your msdn link and some others, would say, you need to add SHFolder.dll before shell32.dll for all windows versions. For Windows98 and WindowsNT users should self install this from here:
http://www.microsoft.com/downloads/details.aspx?displaylang=en&FamilyID=6AE02498-07E9-48F1-A5D6-DBFA18D37E0F

Have installed SHFolder.dll, this file has two functions:
SHGetFolderPathA
SHGetFolderPathW
But no SHGetFolderPath.
'SHGetFolderPath' also not exist in SHELL32.DLL (strings and grepped under Linux)

MSDN says it works with Win98 and IE 5.0 or Win98 SE.
But says nothing about Win98 and IE 6.0

Minimum DLL-Version required: 5.0 ;-(

My SHELL32.DLL Version: 4.72.3612.1700, shipped with installation of Windows 98 SE, buddled with the PC (OEM Version).

Remember: I'm only test it on Windows 98 some times.
I use Monotone daily only on Windows XP and Linux!

Henry Nestler <henryn>
Mon 28 Nov 2005 07:48:25 PM UTC, comment #3:

Thanks. Looks like MSDN has put me wrong, or there's more to the story than they're telling us.

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/platform/shell/reference/functions/shgetfolderpath.asp

I'll put together a patch for win32/fs.cc to test for SHGetFolderPath at runtime.

Thanks again for testing and the bug report.

Matthew Gregan <kinetik>
Project MemberIn charge of this item.
Mon 28 Nov 2005 07:30:00 PM UTC, comment #2:

Have german internet explorer installed and updated with SP1:

Version: 6.0.2800.1106IC
Key-depth: 128-Bit
Updated: SP1

Is no major problem. I'm use monotone all times on XP and Linux. This was only a quick test of this version on my secondary PC.

Henry

Henry Nestler <henryn>
Mon 28 Nov 2005 06:54:54 PM UTC, comment #1:

Thanks for the bug report. You now need Internet Explorer 5.0 or later installed. Considering keeping Internet Explorer up to date is considered a fairly critical for security, this requirement did not seem too onerous. Please let us know if this is going to be a major problem for you.

Matthew Gregan <kinetik>
Project MemberIn charge of this item.
Mon 28 Nov 2005 01:24:09 PM UTC, original submission:

Every command line args popup an error window with missing export of SHGetFolderPathA in SHELL32.

Can not give full version output, no output. Was downloaded from http://www.venge.net/monotone/downloads/monotone-0.24-setup.exe

Henry

Henry Nestler <henryn>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 7 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 14 Dec 2005 07:41:57 AM UTCkinetikStatusLater=>Fixed
  Open/ClosedAnalyzed=>Closed
Mon 28 Nov 2005 09:00:31 PM UTCkinetikStatusInvalid=>Later
  Assigned toNone=>kinetik
  Open/ClosedDeclined=>Analyzed
Mon 28 Nov 2005 06:54:54 PM UTCkinetikStatusNone=>Invalid
  Open/ClosedOpen=>Declined

Back to the top


Powered by Savane 3.1-cleanup1