Mon 28 Nov 2005 09:00:31 PM UTC, comment #5:
To be clear, we are trying to use SHGetFolderPathA in monotone. win32/fs.cc refers to SHGetFolderPath, but this is really just a macro that is #defined in the Windows includes as either SHGetFolderPathA or SHGetFolderPathW, depending on whether you're building for ANSI or Unicode.
I overlooked the 'Remarks' section of the MSDN documentation for this function earlier That section does indeed point towards SHFolder.dll. I suppose they mean that SHGetFolderPath is supported on Win95 if the user has IE5 installed and the software developer has shippped SHFolder.dll with their application.
So, it looks like SHFolder.dll is what you need on earlier versions of Windows, but the released monotone 0.24 binary hasn't been linked against SHFolder.lib, so it won't work out of the box. I'll make sure this is fixed in the next release.
I'm in the process of reviewing our other Win32 API uses, and I'll update the monotone documentation with a specific minimum OS/software requirement list for Windows once I'm complete.
(Also changing the bug to analyzed and 'will fix later', and assigning to me--it's clear now that I haven't handled the use of SHGetFolderPath correctly, so it's a valid bug.)
|