bugGKSu - Bugs: bug #15096, --version-script isn't portable...

 
 

bug #15096: --version-script isn't portable (libgksu and libgksuui)

Submitted by:  Daniel Macks <dmacks>
Submitted on:  Tue 29 Nov 2005 05:33:18 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 01 May 2006 02:47:27 PM UTC, comment #2:

Just commited your patch to trunk/ sorry for taking so long to look into this =( and thanks for the patch!

Gustavo Noronha Silva <kov>
Project Administrator
Thu 01 Dec 2005 03:08:40 AM UTC, comment #1:

Okay, that AC_ configure test is a bit hackish...may as well just steal the one libtool.m4 appears to use when deciding whether to use the --version-script flag (as of libtool-1.5.18):

supports_anon_versioning=no
case `$LD -v 2>/dev/null` in
\ [[01]]. | \ 2.[[0-9]]. | \ 2.10.) ;; # catch versions < 2.11
\ 2.11.93.0.2\ ) supports_anon_versioning=yes ;; # RH7.3 ...
\ 2.11.92.0.12\ ) supports_anon_versioning=yes ;; # Mandrake 8.2 ...
\ 2.11.) ;; # other 2.11 versions
*) supports_anon_versioning=yes ;;
esac

and then use that result:

AM_CONDITIONAL(USE_VERSION_SCRIPT, test x$supports_anon_versioning = xyes)

Daniel Macks <dmacks>
Tue 29 Nov 2005 05:33:18 PM UTC, original submission:

--version-script is only usable on ELF-based platforms. It's a compile-time crash to use it on others. At a minimum, there should be a ./configure flag such as --disable-version-script to make it easy to disable its use when a person compiling knows it should not be used. Better would be to have ./configure automatically check if it can be used.

Daniel Macks <dmacks>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #2507:  version-script-test.libgksuui.patch added by dmacks (2KiB - application/octet-stream - Fixed bug in file #3147)
file #2552:  version-script-test.libgksuui.patch added by dmacks (2KiB - application/octet-stream - add automatic test for --version-script support (for libgksuui))
file #2551:  version-script-test.libgksu.patch added by dmacks (2KiB - application/octet-stream - add automatic test for --version-script support (for libgksu))

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 5 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Mon 01 May 2006 02:47:27 PM UTCkovStatusNone=>Fixed
  Open/ClosedOpen=>Closed
Thu 01 Dec 2005 02:37:28 AM UTCdmacksAttached File-=>Added version-script-test.libgksuui.patch, #3154
Tue 29 Nov 2005 07:06:03 PM UTCdmacksAttached File-=>Added version-script-test.libgksuui.patch, #3147
Tue 29 Nov 2005 07:05:34 PM UTCdmacksAttached File-=>Added version-script-test.libgksu.patch, #3146

Back to the top


Powered by Savane 3.1-cleanup1