bugThe nmh Mail Handling System - Bugs: bug #15285, sbr/Makefile.in: rule for dtimep.c...

 
 

bug #15285: sbr/Makefile.in: rule for dtimep.c doesn't work on BSD make

Submitted by:  Peter Maydell <pm215>
Submitted on:  Sat 24 Dec 2005 05:00:59 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Peter Maydell <pm215>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 24 Dec 2005 06:05:25 PM UTC, comment #2:

forgot to actually close bug...

Peter Maydell <pm215>
Project AdministratorIn charge of this item.
Sat 24 Dec 2005 06:00:02 PM UTC, comment #1:

Fixed in CVS:

/cvsroot/nmh/nmh/ChangeLog,v <-- ChangeLog
new revision: 1.217; previous revision: 1.216
/cvsroot/nmh/nmh/config/Makefile.in,v <-- config/Makefile.in
new revision: 1.4; previous revision: 1.3
/cvsroot/nmh/nmh/sbr/Makefile.in,v <-- sbr/Makefile.in
new revision: 1.20; previous revision: 1.19

Peter Maydell <pm215>
Project AdministratorIn charge of this item.
Sat 24 Dec 2005 05:00:59 PM UTC, original submission:

The rule in sbr/Makefile.in for dtimep.c doesn't work on BSD make because it uses $<, which POSIX says is only guaranteed to work in an inference rule (ie a pattern rule as opposed to a target rule like the one for dtimep.c). GNU make happens to define $< anyway (which is an obvious sensible thing) but BSD make doesn't.

The problem doesn't show up with the distributed tarball because we ship a created dtimep.c, I think.

Fix: explicitly give the input filename rather than using $< in the rule.

We should fix a few other instances of this too, although for .c files the problem is hidden because a system inference rule for %.c causes BSD make to define $<.

Peter Maydell <pm215>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 24 Dec 2005 06:05:25 PM UTCpm215Open/ClosedOpen=>Closed
Sat 24 Dec 2005 06:00:02 PM UTCpm215StatusNone=>Fixed

Back to the top


Powered by Savane 3.1-cleanup1